You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2020/06/11 23:51:07 UTC
[Impala-ASF-CR] IMPALA-9849: Set halt on error=1 for TSAN builds
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16069
Change subject: IMPALA-9849: Set halt_on_error=1 for TSAN builds
......................................................................
IMPALA-9849: Set halt_on_error=1 for TSAN builds
Set halt_on_error to true by default for TSAN builds (we already do this
for ASAN builds). This ensures that Impala crashes whenever a TSAN error
is detected. IMPALA-9568 accidentally broke this.
Testing:
* Ran dataload + be tests in a TSAN build
Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
---
M be/src/common/init.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/16069/1
--
To view, visit http://gerrit.cloudera.org:8080/16069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
Gerrit-Change-Number: 16069
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9849: Set halt on error=1 for TSAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16069 )
Change subject: IMPALA-9849: Set halt_on_error=1 for TSAN builds
......................................................................
IMPALA-9849: Set halt_on_error=1 for TSAN builds
Set halt_on_error to true by default for TSAN builds (we already do this
for ASAN builds). This ensures that Impala crashes whenever a TSAN error
is detected. IMPALA-9568 accidentally broke this.
Testing:
* Ran dataload + be tests in a TSAN build
Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
Reviewed-on: http://gerrit.cloudera.org:8080/16069
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/init.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
Gerrit-Change-Number: 16069
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9849: Set halt on error=1 for TSAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16069 )
Change subject: IMPALA-9849: Set halt_on_error=1 for TSAN builds
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6296/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
Gerrit-Change-Number: 16069
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jun 2020 00:36:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9849: Set halt on error=1 for TSAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16069 )
Change subject: IMPALA-9849: Set halt_on_error=1 for TSAN builds
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
Gerrit-Change-Number: 16069
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 22:07:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9849: Set halt on error=1 for TSAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16069 )
Change subject: IMPALA-9849: Set halt_on_error=1 for TSAN builds
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
Gerrit-Change-Number: 16069
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 16:55:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9849: Set halt on error=1 for TSAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16069 )
Change subject: IMPALA-9849: Set halt_on_error=1 for TSAN builds
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5996/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
Gerrit-Change-Number: 16069
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 16:55:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9849: Set halt on error=1 for TSAN builds
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16069 )
Change subject: IMPALA-9849: Set halt_on_error=1 for TSAN builds
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
Gerrit-Change-Number: 16069
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 15:51:17 +0000
Gerrit-HasComments: No