[GitHub] [skywalking] arugal commented on issue #3724: [test/plugin] container run.sh optimize

[GitBox <gi...@apache.org>]

arugal commented on issue #3724: [test/plugin] container run.sh optimize
URL: https://github.com/apache/skywalking/pull/3724#issuecomment-546711554
 
 
   > The changes don't make sense to me. I assume, you should consider to change verify times, not read time.
   
   There are two scenarios:
   1. ```EntryService``` could not respond, it could be a code bug or something, so we need to set a timeout.
   2. ```EntryService``` takes 7 seconds or more to respond, but eventually it will respond, it has to do with code or vm, so we need a long timeout.
   
   So what we need is a timeout, not a retry
   
   > This is only trying to access receive data, but you don't verify. Why add this?
   
   I can rollback
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services