You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/07 08:13:18 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #3923: never idle batch session and never timeout batch op
turboFei opened a new pull request, #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3923: Add dedicated batch session idle timeout and prevent the batch submission operation timeout
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923#discussion_r1045369428
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -288,6 +288,19 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
ThreadUtils.shutdown(execPool, Duration(shutdownTimeout, TimeUnit.MILLISECONDS))
}
+ protected def checkSessionTimeout(current: Long, session: Session, timeout: Long): Unit = {
+ if (session.lastAccessTime + timeout <= current && session.getNoOperationTime > timeout) {
+ try {
+ closeSession(session.handle)
+ } catch {
+ case e: KyuubiSQLException =>
+ warn(s"Error closing idle session ${session.handle}", e)
+ }
+ } else {
+ session.closeExpiredOperations()
+ }
+ }
+
private def startTimeoutChecker(): Unit = {
val interval = conf.get(SESSION_CHECK_INTERVAL)
val timeout = conf.get(SESSION_IDLE_TIMEOUT)
Review Comment:
thanks, will address it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #3923: Add dedicated batch session idle timeout and prevent the batch submission operation timeout
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923#discussion_r1045361627
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -288,6 +288,19 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
ThreadUtils.shutdown(execPool, Duration(shutdownTimeout, TimeUnit.MILLISECONDS))
}
+ protected def checkSessionTimeout(current: Long, session: Session, timeout: Long): Unit = {
+ if (session.lastAccessTime + timeout <= current && session.getNoOperationTime > timeout) {
+ try {
+ closeSession(session.handle)
+ } catch {
+ case e: KyuubiSQLException =>
+ warn(s"Error closing idle session ${session.handle}", e)
+ }
+ } else {
+ session.closeExpiredOperations()
+ }
+ }
+
private def startTimeoutChecker(): Unit = {
val interval = conf.get(SESSION_CHECK_INTERVAL)
val timeout = conf.get(SESSION_IDLE_TIMEOUT)
Review Comment:
How about add a new field `sessionTimeout` in `Session`. Use `SESSION_IDLE_TIMEOUT ` by default in `AbstractSession`, and use `BATCH_SESSION_IDLE_TIMEOUT` in `KyuubiBatchSessionImpl`.
Then we can make each session use it's own timeout threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #3923: Add dedicated batch session idle timeout and prevent the batch submission operation timeout
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #3923: Add dedicated batch session idle timeout and prevent the batch submission operation timeout
URL: https://github.com/apache/incubator-kyuubi/pull/3923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #3923: Add dedicated batch session idle timeout and prevent the batch submission operation timeout
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923#discussion_r1045361627
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -288,6 +288,19 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
ThreadUtils.shutdown(execPool, Duration(shutdownTimeout, TimeUnit.MILLISECONDS))
}
+ protected def checkSessionTimeout(current: Long, session: Session, timeout: Long): Unit = {
+ if (session.lastAccessTime + timeout <= current && session.getNoOperationTime > timeout) {
+ try {
+ closeSession(session.handle)
+ } catch {
+ case e: KyuubiSQLException =>
+ warn(s"Error closing idle session ${session.handle}", e)
+ }
+ } else {
+ session.closeExpiredOperations()
+ }
+ }
+
private def startTimeoutChecker(): Unit = {
val interval = conf.get(SESSION_CHECK_INTERVAL)
val timeout = conf.get(SESSION_IDLE_TIMEOUT)
Review Comment:
How about add a new filed `sessionTimeout` in `Session`. Use `SESSION_IDLE_TIMEOUT ` by default in `AbstractSession`, and use `BATCH_SESSION_IDLE_TIMEOUT` in `KyuubiBatchSessionImpl`.
Then we can make each session use it's own timeout threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3923: Prevent batch session & operation closed by kyuubi because of timeout
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923#issuecomment-1340829110
> would batch session leak if we disable timeout ?
It will timeout after the operation terminated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3923: Prevent batch session & operation closed by kyuubi because of timeout
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923#issuecomment-1340669762
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3923](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f918dcc) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a0fc33c6af3b53fd1da9b337b0aaa165f562e2bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a0fc33c) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3923 +/- ##
============================================
- Coverage 51.91% 51.89% -0.03%
Complexity 13 13
============================================
Files 508 508
Lines 29019 29036 +17
Branches 3984 3986 +2
============================================
+ Hits 15066 15068 +2
- Misses 12525 12542 +17
+ Partials 1428 1426 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/kyuubi/operation/BatchJobSubmission.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQmF0Y2hKb2JTdWJtaXNzaW9uLnNjYWxh) | `73.10% <0.00%> (-1.55%)` | :arrow_down: |
| [...apache/kyuubi/session/KyuubiBatchSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaUJhdGNoU2Vzc2lvbkltcGwuc2NhbGE=) | `86.07% <0.00%> (-4.60%)` | :arrow_down: |
| [...client/exception/RetryableKyuubiRestException.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2V4Y2VwdGlvbi9SZXRyeWFibGVLeXV1YmlSZXN0RXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/kyuubi/client/RetryableRestClient.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L1JldHJ5YWJsZVJlc3RDbGllbnQuamF2YQ==) | `48.78% <0.00%> (-24.40%)` | :arrow_down: |
| [...main/java/org/apache/kyuubi/client/RestClient.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L1Jlc3RDbGllbnQuamF2YQ==) | `82.75% <0.00%> (-3.45%)` | :arrow_down: |
| [.../org/apache/kyuubi/ha/client/DiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9EaXNjb3ZlcnlDbGllbnQuc2NhbGE=) | `34.78% <0.00%> (-1.59%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `80.74% <0.00%> (-0.63%)` | :arrow_down: |
| [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `79.16% <0.00%> (ø)` | |
| [.../kyuubi/engine/spark/operation/ExecutePython.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVB5dGhvbi5zY2FsYQ==) | `83.51% <0.00%> (+0.08%)` | :arrow_up: |
| [...ha/client/zookeeper/ZookeeperDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvWm9va2VlcGVyRGlzY292ZXJ5Q2xpZW50LnNjYWxh) | `71.72% <0.00%> (+0.14%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/3923/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #3923: Add dedicated batch session idle timeout and prevent the batch submission operation timeout
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923#discussion_r1045361627
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -288,6 +288,19 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
ThreadUtils.shutdown(execPool, Duration(shutdownTimeout, TimeUnit.MILLISECONDS))
}
+ protected def checkSessionTimeout(current: Long, session: Session, timeout: Long): Unit = {
+ if (session.lastAccessTime + timeout <= current && session.getNoOperationTime > timeout) {
+ try {
+ closeSession(session.handle)
+ } catch {
+ case e: KyuubiSQLException =>
+ warn(s"Error closing idle session ${session.handle}", e)
+ }
+ } else {
+ session.closeExpiredOperations()
+ }
+ }
+
private def startTimeoutChecker(): Unit = {
val interval = conf.get(SESSION_CHECK_INTERVAL)
val timeout = conf.get(SESSION_IDLE_TIMEOUT)
Review Comment:
How about add a new field `sessionIdelTimeoutThreshold` in `Session`. Use `SESSION_IDLE_TIMEOUT ` by default in `AbstractSession`, and use `BATCH_SESSION_IDLE_TIMEOUT` in `KyuubiBatchSessionImpl`.
Then we can make each session use it's own timeout threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #3923: Prevent batch session & operation closed by kyuubi because of timeout
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923#issuecomment-1340685591
would batch session leak if we disable timeout ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #3923: Add dedicated batch session idle timeout and prevent the batch submission operation timeout
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923#discussion_r1045361627
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -288,6 +288,19 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
ThreadUtils.shutdown(execPool, Duration(shutdownTimeout, TimeUnit.MILLISECONDS))
}
+ protected def checkSessionTimeout(current: Long, session: Session, timeout: Long): Unit = {
+ if (session.lastAccessTime + timeout <= current && session.getNoOperationTime > timeout) {
+ try {
+ closeSession(session.handle)
+ } catch {
+ case e: KyuubiSQLException =>
+ warn(s"Error closing idle session ${session.handle}", e)
+ }
+ } else {
+ session.closeExpiredOperations()
+ }
+ }
+
private def startTimeoutChecker(): Unit = {
val interval = conf.get(SESSION_CHECK_INTERVAL)
val timeout = conf.get(SESSION_IDLE_TIMEOUT)
Review Comment:
How about add a new field `sessionIdleTimeoutThreshold` in `Session`. Use `SESSION_IDLE_TIMEOUT ` by default in `AbstractSession`, and use `BATCH_SESSION_IDLE_TIMEOUT` in `KyuubiBatchSessionImpl`.
Then we can make each session use it's own timeout threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3923: Add dedicated batch session idle timeout and prevent the batch submission operation timeout
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3923:
URL: https://github.com/apache/incubator-kyuubi/pull/3923#issuecomment-1345862501
thanks, merged to master and 1.6.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org