You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/01 03:50:02 UTC
[jira] [Commented] (NETBEANS-73) Git Private Key Setting Could be
Smarter
[ https://issues.apache.org/jira/browse/NETBEANS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187272#comment-16187272 ]
ASF GitHub Bot commented on NETBEANS-73:
----------------------------------------
Github user lkishalmi commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/25#discussion_r142020017
--- Diff: git/src/org/netbeans/modules/git/ui/repository/remote/RemoteRepository.java ---
@@ -686,6 +686,7 @@ public SSHConnectionSettingsType () {
settingsPanel.savePasswordCheckBox
};
acceptableSchemes = EnumSet.of(Scheme.SSH, Scheme.SFTP);
+ settingsPanel.txtIdentityFile.setText(getDefaultIdentityFilePath());
--- End diff --
Unfortunately populateFields is not called in every case. Most importantly when the repository URL is being copied from github/gitlab where the ssh:// prefix is just missing from the URL. Probably I could raise a bug on that. And mark this line as a workaround in the code, till it gets fixed. I feel the fix would be a bit out of the trivial category.
> Git Private Key Setting Could be Smarter
> ----------------------------------------
>
> Key: NETBEANS-73
> URL: https://issues.apache.org/jira/browse/NETBEANS-73
> Project: NetBeans
> Issue Type: Improvement
> Components: versioncontrol - Git
> Affects Versions: 8.2
> Reporter: Laszlo Kishalmi
> Priority: Trivial
> Labels: easyfix, patch
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> I guess it is more common to use {{id_rsa}} keys nowadays than {{id_dsa}}. Whenever I clone a repository that I use with ssh, I need to click on private key authentication then browse, and the browse select {{id_dsa}} which I do not have and I have to select my {{id_rsa}} file and close.
> It would be much nicer to pre-fill the input field with the user's {{id_rsa}} or {{id_dsa}} whatever they have ({{id_rsa}} preferred).
> Also this could be done on Windows (where {{id_dsa}} not selected in the Open File dialog) as well as several Windows Git client uses {{%HOME%\.ssh\id_rsa}} as default.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)