[GitHub] [hudi] beyond1920 commented on a diff in pull request #7801: [HUDI-5657] Fix NPE if filters condition contains null literal when using column stats data skipping for flink

["beyond1920 (via GitHub)" <gi...@apache.org>]

beyond1920 commented on code in PR #7801:
URL: https://github.com/apache/hudi/pull/7801#discussion_r1093081559


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/stats/ExpressionEvaluator.java:
##########
@@ -282,6 +286,9 @@ public static LessThan getInstance() {
 
     @Override
     public boolean eval() {
+      if (this.val == null) {
+        return false;
+      }

Review Comment:
   Sure.
   I introduce a new evaluator to handle this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org