You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by britter <gi...@git.apache.org> on 2018/09/05 12:31:37 UTC
[GitHub] commons-lang pull request #354: Convert tests for Validate.isTrue overloads ...
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/354
Convert tests for Validate.isTrue overloads to @Nested test
Proposal for a better structure of tests using `@Nested`. Each method should have it's own `@Nested` container which is called like the method. Inside that container each overload has it's own `@Nested` container. I did this for `Validate.isTrue` to show the approach.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/commons-lang nested-validate-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/354.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #354
----
commit aad2db8b12b8c61556df9df7de4fadc927633504
Author: Benedikt Ritter <br...@...>
Date: 2018-09-05T12:26:25Z
Convert tests for Validate.isTrue overloads to @Nested test
----
---
[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/354
[](https://coveralls.io/builds/18838060)
Coverage remained the same at 95.253% when pulling **aad2db8b12b8c61556df9df7de4fadc927633504 on britter:nested-validate-test** into **bce28f99f383051b419510ef72531e0f6fa67352 on apache:master**.
---
[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/354
@kinow @PascalSchumacher @chtompki WDYT?
---
[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/354
+1
---
[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/354
Okay, as there is positive feedback for this change, I'm going to migrate the whole `ValidateTest` to this style and then merge it 👍
---
[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/354
Build failure seems to be unrelated.
---
[GitHub] commons-lang pull request #354: Convert tests for Validate.isTrue overloads ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/354
---