You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "nizhikov (via GitHub)" <gi...@apache.org> on 2023/05/26 17:07:24 UTC
[GitHub] [ignite] nizhikov opened a new pull request, #10741: IGNITE-15629 Cache index list command implemented
nizhikov opened a new pull request, #10741:
URL: https://github.com/apache/ignite/pull/10741
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov merged pull request #10741: IGNITE-15629 Cache index list command implemented
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov merged PR #10741:
URL: https://github.com/apache/ignite/pull/10741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10741: IGNITE-15629 Cache index list command implemented
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10741:
URL: https://github.com/apache/ignite/pull/10741#issuecomment-1565399532
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10741)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=BUG) [4 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10741&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10741&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10741&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=CODE_SMELL) [72 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_duplicated_lines_density&view=list) [3.3% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a diff in pull request #10741: IGNITE-15629 Cache index list command implemented
Posted by "ivandasch (via GitHub)" <gi...@apache.org>.
ivandasch commented on code in PR #10741:
URL: https://github.com/apache/ignite/pull/10741#discussion_r1211992485
##########
modules/core/src/main/java/org/apache/ignite/internal/visor/verify/VisorValidateIndexesTask.java:
##########
@@ -106,19 +108,19 @@ private static class VisorValidateIndexesJob extends VisorJob<VisorValidateIndex
* @param arg Argument.
* @param debug Debug.
*/
- protected VisorValidateIndexesJob(@Nullable VisorValidateIndexesTaskArg arg, boolean debug) {
+ protected VisorValidateIndexesJob(@Nullable CacheValidateIndexesCommandArg arg, boolean debug) {
super(arg, debug);
}
/** {@inheritDoc} */
- @Override protected VisorValidateIndexesJobResult run(@Nullable VisorValidateIndexesTaskArg arg) throws IgniteException {
+ @Override protected VisorValidateIndexesJobResult run(@Nullable CacheValidateIndexesCommandArg arg) throws IgniteException {
Review Comment:
arg is nullable, but there is no code to cover this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10741: IGNITE-15629 Cache index list command implemented
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10741:
URL: https://github.com/apache/ignite/pull/10741#issuecomment-1570577612
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10741)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10741&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10741&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10741&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=CODE_SMELL) [23 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a diff in pull request #10741: IGNITE-15629 Cache index list command implemented
Posted by "ivandasch (via GitHub)" <gi...@apache.org>.
ivandasch commented on code in PR #10741:
URL: https://github.com/apache/ignite/pull/10741#discussion_r1211989284
##########
modules/core/src/main/java/org/apache/ignite/internal/management/api/CommandUtils.java:
##########
@@ -284,6 +287,65 @@ public static <T> T parseVal(String val, Class<T> type) {
.orElse(null);
}
+ /**
+ * Join input parameters with specified {@code delimeter} between them.
+ *
+ * @param delimeter Specified delimeter.
+ * @param params Other input parameter.
+ * @return Joined paramaters with specified {@code delimeter}.
+ */
+ public static String join(String delimeter, Object... params) {
+ return join(new SB(), "", delimeter, params).toString();
+ }
+
+ /**
+ * Join input parameters with specified {@code delimeter} between them and append to the end {@code delimeter}.
+ *
+ * @param sb Specified string builder.
+ * @param sbDelimeter Delimeter between {@code sb} and appended {@code param}.
+ * @param delimeter Specified delimeter.
+ * @param params Other input parameter.
+ * @return SB with appended to the end joined paramaters with specified {@code delimeter}.
+ */
+ public static SB join(SB sb, String sbDelimeter, String delimeter, Object... params) {
+ if (!F.isEmpty(params)) {
+ sb.a(sbDelimeter);
+
+ for (Object par : params)
+ sb.a(par).a(delimeter);
+
+ sb.setLength(sb.length() - delimeter.length());
+ }
+
+ return sb;
+ }
+
+ /**
+ * Prints exception messages to log
+ *
+ * @param exceptions map containing node ids and exceptions.
+ * @param infoMsg single message to log.
+ * @param printer Printer to use.
+ * @return true if errors were printed.
+ */
+ public static boolean printErrors(Map<UUID, Exception> exceptions, String infoMsg, Consumer<String> printer) {
+ if (!F.isEmpty(exceptions)) {
Review Comment:
May be just
```
if (F.isEmpty(exceptions))
return false;
....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a diff in pull request #10741: IGNITE-15629 Cache index list command implemented
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on code in PR #10741:
URL: https://github.com/apache/ignite/pull/10741#discussion_r1211994480
##########
modules/core/src/main/java/org/apache/ignite/internal/management/api/CommandUtils.java:
##########
@@ -284,6 +287,65 @@ public static <T> T parseVal(String val, Class<T> type) {
.orElse(null);
}
+ /**
+ * Join input parameters with specified {@code delimeter} between them.
+ *
+ * @param delimeter Specified delimeter.
+ * @param params Other input parameter.
+ * @return Joined paramaters with specified {@code delimeter}.
+ */
+ public static String join(String delimeter, Object... params) {
+ return join(new SB(), "", delimeter, params).toString();
+ }
+
+ /**
+ * Join input parameters with specified {@code delimeter} between them and append to the end {@code delimeter}.
+ *
+ * @param sb Specified string builder.
+ * @param sbDelimeter Delimeter between {@code sb} and appended {@code param}.
+ * @param delimeter Specified delimeter.
+ * @param params Other input parameter.
+ * @return SB with appended to the end joined paramaters with specified {@code delimeter}.
+ */
+ public static SB join(SB sb, String sbDelimeter, String delimeter, Object... params) {
+ if (!F.isEmpty(params)) {
+ sb.a(sbDelimeter);
+
+ for (Object par : params)
+ sb.a(par).a(delimeter);
+
+ sb.setLength(sb.length() - delimeter.length());
+ }
+
+ return sb;
+ }
+
+ /**
+ * Prints exception messages to log
+ *
+ * @param exceptions map containing node ids and exceptions.
+ * @param infoMsg single message to log.
+ * @param printer Printer to use.
+ * @return true if errors were printed.
+ */
+ public static boolean printErrors(Map<UUID, Exception> exceptions, String infoMsg, Consumer<String> printer) {
+ if (!F.isEmpty(exceptions)) {
Review Comment:
Yes. Fixed.
##########
modules/core/src/main/java/org/apache/ignite/internal/visor/verify/VisorValidateIndexesTask.java:
##########
@@ -106,19 +108,19 @@ private static class VisorValidateIndexesJob extends VisorJob<VisorValidateIndex
* @param arg Argument.
* @param debug Debug.
*/
- protected VisorValidateIndexesJob(@Nullable VisorValidateIndexesTaskArg arg, boolean debug) {
+ protected VisorValidateIndexesJob(@Nullable CacheValidateIndexesCommandArg arg, boolean debug) {
super(arg, debug);
}
/** {@inheritDoc} */
- @Override protected VisorValidateIndexesJobResult run(@Nullable VisorValidateIndexesTaskArg arg) throws IgniteException {
+ @Override protected VisorValidateIndexesJobResult run(@Nullable CacheValidateIndexesCommandArg arg) throws IgniteException {
Review Comment:
assert added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10741: IGNITE-15629 Cache index list command implemented
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10741:
URL: https://github.com/apache/ignite/pull/10741#issuecomment-1569767037
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10741)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10741&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10741&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10741&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=CODE_SMELL) [22 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10741&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10741&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org