You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/22 09:17:17 UTC

[GitHub] [pulsar] nicoloboschi opened a new pull request #14796: [tests] Add Kinesis Sink integration tests

nicoloboschi opened a new pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796


   ### Motivation
   
   Kinesis sink doesn't have integration tests.
   
   ### Modifications
   * Added two config props needed for testing:
     * skipCertificateValidation: Boolean, default false
     * awsEndpointPort: Integer, default null, if null will use the default client port
   * Added integration tests with mock pulsar (under pulsar-io/kinesis dir) using localstack image and testcontainers.
   * Added integration tests with real pulsar (under integrations dir) using localstack image and testcontainers.
   
   - [x] `no-need-doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nicoloboschi commented on pull request #14796: [tests] Add Kinesis Sink integration tests

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796#issuecomment-1076513110


   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nicoloboschi closed pull request #14796: [tests] Add Kinesis Sink integration tests

Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli merged pull request #14796: [tests] Add Kinesis Sink integration tests

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nicoloboschi commented on pull request #14796: [tests] Add Kinesis Sink integration tests

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796#issuecomment-1080359097


   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nicoloboschi commented on pull request #14796: [tests] Add Kinesis Sink integration tests

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796#issuecomment-1075192998


   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nicoloboschi commented on pull request #14796: [tests] Add Kinesis Sink integration tests

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796#issuecomment-1077713710


   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nicoloboschi commented on pull request #14796: [tests] Add Kinesis Sink integration tests

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796#issuecomment-1080359332


   @lhotari @michaeljmarshall  @dlg99 PTAL 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nicoloboschi closed pull request #14796: [tests] Add Kinesis Sink integration tests

Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nicoloboschi closed pull request #14796: [tests] Add Kinesis Sink integration tests

Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #14796:
URL: https://github.com/apache/pulsar/pull/14796


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org