[Resurect] Re: SubRequest in Handler vs SubRequest in Filter - and Segmentation Fault

["Philip M. Gollucci" <pg...@p6m7g8.com>]

Which of these was the final verdict?  I talked to Stas a while ago and he was for committing it
which I'd like to do to resolve this issue.


Stas Bekman wrote:
> Index: xs/Apache2/SubRequest/Apache2__SubRequest.h
> ===================================================================
> --- xs/Apache2/SubRequest/Apache2__SubRequest.h (revision 419996)
> +++ xs/Apache2/SubRequest/Apache2__SubRequest.h (working copy)
> @@ -20,7 +20,7 @@
>       * output before anything already written in the main request
>       */
> 
> -    if (r->main) {
> +    if (r->main && rcfg->wbucket) {
>          modperl_config_req_t *rcfg = modperl_config_req_get(r->main);
>          MP_RUN_CROAK(modperl_wbucket_flush(rcfg->wbucket, FALSE),
>                       "Apache2::SubRequest::run");

Scott Penrose wrote:
>    if (r->main) {
>         modperl_config_req_t *rcfg = modperl_config_req_get(r->main);
>+    if (rcfg->wbucket)
>             MP_RUN_CROAK(modperl_wbucket_flush(rcfg->wbucket, FALSE),
>                      "Apache2::SubRequest::run");


-- 
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."