You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/23 09:51:09 UTC
[GitHub] [incubator-kvrocks] jackwener opened a new pull request, #653: fix: fix problem found by tsan
jackwener opened a new pull request, #653:
URL: https://github.com/apache/incubator-kvrocks/pull/653
close #639
fix problem found by tsan.
Thanks @PragmaTwice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #653: fix: fix the warning.
Posted by GitBox <gi...@apache.org>.
git-hulk commented on code in PR #653:
URL: https://github.com/apache/incubator-kvrocks/pull/653#discussion_r904944275
##########
.gitignore:
##########
@@ -31,17 +31,23 @@
*.out
*.app
-.idea/
-cmake-build-debug
*.o
*.pyc
*.swp
*.swo
.DS_Store
-kvrocks
version.h
-Makefile.dep
-make_config.mk
+
+.idea/
.vscode
+.cache
+
+kvrocks
kvrocks2redis
+compactdb
+testsdb
+
build
+cmake-build-debug
+make_config.mk
+Makefile.dep
Review Comment:
```suggestion
```
We have removed the makefile, so will not generate those files again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #653: Fix compile warnings in kvrocks
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #653:
URL: https://github.com/apache/incubator-kvrocks/pull/653#issuecomment-1165167075
Thanks for your contribution! Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #653: fix: fix the warning.
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #653:
URL: https://github.com/apache/incubator-kvrocks/pull/653#discussion_r904948784
##########
.gitignore:
##########
@@ -31,17 +31,23 @@
*.out
*.app
-.idea/
-cmake-build-debug
*.o
*.pyc
*.swp
*.swo
.DS_Store
-kvrocks
version.h
-Makefile.dep
-make_config.mk
+
+.idea/
.vscode
+.cache
+
+kvrocks
kvrocks2redis
Review Comment:
```suggestion
```
I think these files can be remove since these are in build directories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #653: fix: fix the warning.
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #653:
URL: https://github.com/apache/incubator-kvrocks/pull/653#discussion_r904946826
##########
.gitignore:
##########
@@ -31,17 +31,23 @@
*.out
*.app
-.idea/
-cmake-build-debug
*.o
*.pyc
*.swp
*.swo
.DS_Store
-kvrocks
version.h
-Makefile.dep
-make_config.mk
+
+.idea/
.vscode
+.cache
+
+kvrocks
kvrocks2redis
+compactdb
+testsdb
+
build
+cmake-build-debug
Review Comment:
```suggestion
cmake-build-*
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #653: Fix compile warnings in kvrocks
Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #653:
URL: https://github.com/apache/incubator-kvrocks/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] jackwener commented on pull request #653: fix: fix problem found by tsan
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #653:
URL: https://github.com/apache/incubator-kvrocks/pull/653#issuecomment-1164226380
raiseError() is a little strange, it is an unreturned function.
Reasonably, we should return void. But it will influent origin logic.
So, I don't handle it. It's a future ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] jackwener commented on pull request #653: [WIP] fix: fix problem found by tsan
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #653:
URL: https://github.com/apache/incubator-kvrocks/pull/653#issuecomment-1164301601
I have tried four time but failed reproduce it.😂.
Env:
- mbp m1
See this problem later (other PR), this PR just fix warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org