You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by willholley <gi...@git.apache.org> on 2015/02/06 19:15:27 UTC
[GitHub] couchdb-fabric pull request: Respect doc_options during _all_docs ...
GitHub user willholley opened a pull request:
https://github.com/apache/couchdb-fabric/pull/13
Respect doc_options during _all_docs serialization
When full documents are returned as part of an _all_docs response, respect doc_options (e.g. attachments=true) during JSON serialization. This only affects the code path taken when specific keys are requested - the standard _all_docs handling seems to deal with these options as expected.
Fixes COUCHDB-2568
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/willholley/couchdb-fabric 2568-support-attachments-true-all-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fabric/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 4a0f1e6e17b665c21a23f4b392c50aae7abb8e0b
Author: Will Holley <wi...@gmail.com>
Date: 2015-02-06T17:52:31Z
Respect doc_options during _all_docs serialization
When full documents are returned as part of an _all_docs response,
respect doc_options (e.g. attachments=true) during JSON serialization.
Fixes COUCHDB-2568
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Respect doc_options during _all_docs ...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/13#issuecomment-73861311
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Respect doc_options during _all_docs ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fabric/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Respect doc_options during _all_docs ...
Posted by willholley <gi...@git.apache.org>.
Github user willholley commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/13#issuecomment-73856750
Is somebody able to review this? It would make another swath of PouchDB tests happy if we can get COUCHDB-2568 fixed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---