You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/01 09:45:06 UTC

[GitHub] [airflow] flvndh commented on pull request #11015: Add Azure Data Factory hook

flvndh commented on pull request #11015:
URL: https://github.com/apache/airflow/pull/11015#issuecomment-770722905


   @RosterIn Most of the warnings are caused by the pytest [setup](https://docs.pytest.org/en/stable/xunit_setup.html#module-level-setup-teardown) and [fixture](https://docs.pytest.org/en/stable/fixture.html#requesting-fixtures).
   
   For the `Too many public methods (28/27)` I could move related methods into their own object and the API could look like this:
   ```python
   >>> hook.factory.get(...)
   >>> hook.factory.create(...)
   >>> hook.trigger.update(...)
   >>> hook.dataset.delete(...)
   ```
   but this is quite close to what the Microsoft SDK does. @feluelle what's your view on that ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org