You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2017/05/12 23:49:59 UTC
Review Request 59251: LuceneClientSecurityDUnitTest was not testing
anything
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59251/
-----------------------------------------------------------
Review request for geode and Barry Oglesby.
Repository: geode
Description
-------
This test was just creating lambdas without executing them. Changing the
test to actually run some tests.
Diffs
-----
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneClientSecurityDUnitTest.java 67103ffffcf0f56b99ef306778cc08118a00b72d
Diff: https://reviews.apache.org/r/59251/diff/1/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 59251: LuceneClientSecurityDUnitTest was not
testing anything
Posted by Lynn Hughes-Godfrey <lh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59251/#review174873
-----------------------------------------------------------
Ship it!
Ship It!
- Lynn Hughes-Godfrey
On May 12, 2017, 11:49 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59251/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 11:49 p.m.)
>
>
> Review request for geode and Barry Oglesby.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This test was just creating lambdas without executing them. Changing the
> test to actually run some tests.
>
>
> Diffs
> -----
>
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneClientSecurityDUnitTest.java 67103ffffcf0f56b99ef306778cc08118a00b72d
>
>
> Diff: https://reviews.apache.org/r/59251/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>