[jira] [Commented] (BOOKKEEPER-369) re-factor hedwig cpp client to provide better interface to support both one-subscription-per-channel and multiple-subscriptions-per-channel.

["Ivan Kelly (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469442#comment-13469442 ] 

Ivan Kelly commented on BOOKKEEPER-369:
---------------------------------------

The new patch looks good for the most part. However, ActiveSubscriber calls channel->stopReceiving a number of times. As channels are to be shared among subscribers, this seems incorrect. Is this an oversight or something you purposefully left to be fixed later?
                
> re-factor hedwig cpp client to provide better interface to support both one-subscription-per-channel and multiple-subscriptions-per-channel.
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-369
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-369
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-369.diff, BOOKKEEPER-369.diff
>
>
> provide better interface to support both mode, like java client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira