You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2019/10/30 13:38:32 UTC
[Bug 63893] New: Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Bug ID: 63893
Summary: Bogus warning "unsupported command 20"
Product: Apache httpd-2
Version: 2.4.38
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: mod_remoteip
Assignee: bugs@httpd.apache.org
Reporter: charlemagnelasse@gmail.com
Target Milestone: ---
My log filled just my complete EC2 HDD because apache remoteip spams my logs
full with "RemoteIPProxyProtocol: unsupported command 20". This is caused by
the health checks of AWS's NLB - which sends LOCAL ver_cmd proxy headers to
check for problems.
This is (according to the spec
https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt) a valid ver_cmd
and shouldn't cause these kind of log spam.
See "9. Sample code" for details.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #15 from axel.schmidt@rz.uni-augsburg.de ---
I also still seeing the same errors in Apache/2.4.58.
Just tried the patch and this would also be the solution for me.
What are the chances that this patch will finally be merged?
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
chip.edwards@galaxypost.net changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chip.edwards@galaxypost.net
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Eric Covener <co...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
Keywords| |PatchAvailable
--- Comment #2 from Eric Covener <co...@gmail.com> ---
(In reply to Giovanni Bechis from comment #1)
> Created attachment 36986 [details]
> Patch to prevent from logging local proxy connections
desk-checking patch and not too familiar with this module/protocol, should we
be returning over the apr_sockaddr_ip_get() below the switch?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #11 from Yann Ylavic <yl...@gmail.com> ---
(In reply to Avinash S from comment #10)
> would like to contribute in bug fixes/new features.
> Could you please help me in providing details on process for the same.
Thanks for proposing!
The best way to contribute is to propose the patch(es) and rationale on the
dev@httpd.apache.org mailing list, or for existing bugzilla tickets simply
attach the proposed fix there.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #12 from Paulo M <me...@gmail.com> ---
I'm having the same problem caused by AWS's NLB use of LOCAL.
I have tried the two patches and it successfully stopped the
"RemoteIPProxyProtocol: unsupported command 20" and the log of 400 errors which
makes the NLB health check pass.
However, I'm still seeing a bunch of these happening which are generated by the
same health check requests:
[remoteip:error] [pid 9861:tid 140156862461504] (70014)End of file found:
[client 10.0.0.x:22257] AH10184: failed reading input
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Joe Orton <jo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #16 from Joe Orton <jo...@apache.org> ---
The logging part is now fixed as well here:
https://github.com/apache/httpd/commit/3f95bd3fe64f29403633d283343c26a3997d7c04#diff-93bbef8464dee7b41b6e1a90619c8d96168206196b31497bd5d39fed9af8635e
I will propose both parts of this for backport to 2.4.x
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #1 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 36986
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36986&action=edit
Patch to prevent from logging local proxy connections
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #4 from Joe Orton <jo...@redhat.com> ---
Doing "return HDR_DONE" in the LOCAL case looks simpler
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Avinash S <av...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEEDINFO |RESOLVED
Keywords| |FixedInTrunk
--- Comment #6 from Giovanni Bechis <gi...@paclan.it> ---
Committed to trunk in r1874344.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #10 from Avinash S <av...@gmail.com> ---
Hi Joe,
This patch is working fine.
Hi Joe, would like to contribute in bug fixes/new features.
Could you please help me in providing details on process for the same.
Thanks,
Avinash
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #36986|0 |1
is obsolete| |
--- Comment #3 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 36992
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36992&action=edit
prevent logging local proxy connections
From protocol specs
(https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt):
"...When used with a LOCAL command, the receiver must accept the connection and
ignore any address information...."
The updated patch doesn't compute the client ip in the local connection case.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Paulo M <me...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cheng0201@gmail.com
--- Comment #13 from Paulo M <me...@gmail.com> ---
*** Bug 62866 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #9 from Joe Orton <jo...@redhat.com> ---
Created attachment 37712
--> https://bz.apache.org/bugzilla/attachment.cgi?id=37712&action=edit
don't log 400 for LOCAL PROXY connections
Can you try this patch? We really need a test suite for this stuff. :(
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Bertrand Jacquin <be...@jacquin.bzh> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bertrand@jacquin.bzh
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #8 from Avinash S <av...@gmail.com> ---
Btw, I was developing proxy protocol for my company and found across this issue
still.
is the above mentioned fix is fine ?
what's your opinion ?
Thanks,
Avinash
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #36992|0 |1
is obsolete| |
--- Comment #5 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 36993
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36993&action=edit
prevent logging local proxy connections
Looks fine as well, diff updated.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #7 from Avinash S <av...@gmail.com> ---
This looks to be not working still.
Since, we are checking for
if (!conn_config->client_addr) {
ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, APLOGNO(03496)
"RemoteIPProxyProtocol data is missing, but required!
Aborting request.");
return HTTP_BAD_REQUEST;
}
We still return 400 Bad requests.
We may need to do something like below under switch statement
case 0x00: /* LOCAL command */
case 0x01: /* PROXY command */
switch (hdr->v2.fam) {
case 0x11: /* TCPv4 */
ret = apr_sockaddr_info_get(&conn_conf->client_addr, NULL,
APR_INET,
ntohs(hdr->v2.addr.ip4.src_port),
0, c->pool
And go ahead parsing client info even for LOCAL and so that
conn_config->client_addr is populated.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
Paulo M <me...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mentalstring+apache@gmail.c
| |om
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #14 from Sarva <sb...@gmail.com> ---
Still seeing the same errors in Apache/2.4.53, any idea when this patch will be
merged? Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org