You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "leezng (via GitHub)" <gi...@apache.org> on 2023/03/20 02:11:42 UTC

[GitHub] [inlong] leezng commented on a diff in pull request #7644: [INLONG-7643][Dashboard] Support specifying buckets when creating kudu resource

leezng commented on code in PR #7644:
URL: https://github.com/apache/inlong/pull/7644#discussion_r1141558396


##########
inlong-dashboard/src/metas/sinks/defaults/Kudu.ts:
##########
@@ -118,6 +118,19 @@ export default class KuduSink extends SinkInfo implements DataWithBackend, Rende
   @I18n('meta.Sinks.EnableCreateResource')
   enableCreateResource: number;
 
+  @FieldDecorator({
+    type: 'input',
+    initialValue: '',
+    rules: [{ required: false }],
+    props: values => ({
+      disabled: [110, 130].includes(values?.status),
+    }),
+    visible: values => values!.enableCreateResource == '1',

Review Comment:
   * `==` must change to `===`
   * '1' must change to number
   
   Such as `enableCreateResource === 1`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org