You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/04/04 17:43:27 UTC
[jira] [Commented] (QPID-3918) Add management acl-query test
methods to C++ broker ACL plugin
[ https://issues.apache.org/jira/browse/QPID-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246377#comment-13246377 ]
jiraposter@reviews.apache.org commented on QPID-3918:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4525/
-----------------------------------------------------------
(Updated 2012-04-04 15:42:02.279036)
Review request for qpid, Alan Conway, Gordon Sim, and rajith attapattu.
Changes
-------
Use the management hooks in the acl.py self test.
There are two parts to the ACL tests: 1) When something happens in the broker does the correct authorise() function get called? and 2) When an authorise() function gets called does the ACL logic evaluate correctly? This patch addresses part 2 making it clear and easy to test the ACL logic.
Summary
-------
Add management methods that let a customer drive arbitrary ACL lookup queries.
This addresses bug QPID-3918.
https://issues.apache.org/jira/browse/QPID-3918
Diffs (updated)
-----
trunk/qpid/cpp/src/qpid/acl/Acl.h 1307073
trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1307073
trunk/qpid/cpp/src/qpid/acl/management-schema.xml 1307073
trunk/qpid/cpp/src/qpid/broker/AclModule.h 1307073
trunk/qpid/cpp/src/tests/acl.py 1307073
trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1307073
Diff: https://reviews.apache.org/r/4525/diff
Testing
-------
Thanks,
Chug
> Add management acl-query test methods to C++ broker ACL plugin
> --------------------------------------------------------------
>
> Key: QPID-3918
> URL: https://issues.apache.org/jira/browse/QPID-3918
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker
> Affects Versions: 0.14
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Attachments: acl-test-01-brokerlog.txt, acl-test-01-rules.acl, acl-test-01.log, acl-test-01.py
>
>
> In its current form the ACL module is not testable in a customer deployment. The ACL module loads the ACL file and from then on only real-world activity triggers allow and deny decisions.
> This feature proposal adds two management methods that are directly tied to the ACL decision Lookup functions. Using them a customer may start a dummy broker process that uses his actual (1) ACL rule file. Then using a management application the customer may fire off a set of lookups against his rule file to see if the ACL rules deliver the intended results.
> This feature could also be used to augment the self tests. It is very hard to stage enough driver code to trigger some of the ACL queries. Using the proposed methods then the self test can launch any ACL query directly.
> (1) As usual the ACL file must be bent enough to allow 'anonymous' to have access to the management methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org