You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by Zoltan Farkas <zo...@yahoo.com.INVALID> on 2015/12/09 21:10:49 UTC
Can somebody look at: https://issues.apache.org/jira/browse/AVRO-1723
This is quite a nice improvement to the avro IDL, and the amount of code is small.
thank you
—Z
Re: Can somebody look at: https://issues.apache.org/jira/browse/AVRO-1723
Posted by Zoltan Farkas <zo...@yahoo.com.INVALID>.
Sure,
The patch I have attached to AVRO-1723 <https://issues.apache.org/jira/browse/AVRO-1723> includes the fixes from AVRO-1667 (The included unit test would fail otherwise).
I have created the patch based on the latest trunk at the time. (Doug asked for it in order to review the changes easier)
you can either use the attached patch or merge the branch: https://github.com/zolyfarkas/avro/tree/trunk-AVRO-1723 (rebased it now to latest trunk)
Let me know if there is anything I can do to help with this.
—Z
> On Dec 9, 2015, at 4:49 PM, Ryan Blue <bl...@cloudera.com> wrote:
>
> Zoltan, thanks for taking the time to contribute this patch. I've been watching this one and IIRC it is pretty close.
>
> One thing that makes it more difficult is that it depends on AVRO-1667 and the linked branch includes another uncommitted fix. Sorting that out actually prevented me from looking at it a couple weeks ago and it would be awesome if you had the time to determine what is really blocking the patch and work with me on the other issues first.
>
> Lets focus on getting AVRO-1667 in and then we'll get this done. Does that work for you?
>
> rb
>
> On 12/09/2015 12:10 PM, Zoltan Farkas wrote:
>> This is quite a nice improvement to the avro IDL, and the amount of code is small.
>>
>> thank you
>>
>> —Z
>>
>
>
> --
> Ryan Blue
> Software Engineer
> Cloudera, Inc.
Re: Can somebody look at:
https://issues.apache.org/jira/browse/AVRO-1723
Posted by Ryan Blue <bl...@cloudera.com>.
Zoltan, thanks for taking the time to contribute this patch. I've been
watching this one and IIRC it is pretty close.
One thing that makes it more difficult is that it depends on AVRO-1667
and the linked branch includes another uncommitted fix. Sorting that out
actually prevented me from looking at it a couple weeks ago and it would
be awesome if you had the time to determine what is really blocking the
patch and work with me on the other issues first.
Lets focus on getting AVRO-1667 in and then we'll get this done. Does
that work for you?
rb
On 12/09/2015 12:10 PM, Zoltan Farkas wrote:
> This is quite a nice improvement to the avro IDL, and the amount of code is small.
>
> thank you
>
> —Z
>
--
Ryan Blue
Software Engineer
Cloudera, Inc.