You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2014/11/20 18:20:45 UTC
Review Request 28285: HIVE-8435
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28285/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-8435
https://issues.apache.org/jira/browse/HIVE-8435
Repository: hive-git
Description
-------
HIVE-8435
Added an additional check to know whether the SelectOp swaps columns.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java dabe2a8d1cdf6a3b57a3fb34a9791a824e6b22e7
ql/src/test/results/clientpositive/multiMapJoin1.q.out 26eca26f17bfccb242c79c54732dfe3fe726aada
Diff: https://reviews.apache.org/r/28285/diff/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 28285: HIVE-8926
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28285/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 11:24 a.m.)
Review request for hive and Ashutosh Chauhan.
Summary (updated)
-----------------
HIVE-8926
Bugs: HIVE-8926
https://issues.apache.org/jira/browse/HIVE-8926
Repository: hive-git
Description (updated)
-------
HIVE-8926
Added an additional check to know whether the SelectOp swaps columns.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java dabe2a8d1cdf6a3b57a3fb34a9791a824e6b22e7
ql/src/test/results/clientpositive/infer_bucket_sort.q.out c72d68e075fd21a280b7fa52c529e425c686d133
ql/src/test/results/clientpositive/infer_bucket_sort_reducers_power_two.q.out ca484eb43a235d7404b7b92bf17dbda11d6b0dfc
ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 7b61904116eff9dc52beb1137fa43d3ef09d3c83
ql/src/test/results/clientpositive/multiMapJoin1.q.out 26eca26f17bfccb242c79c54732dfe3fe726aada
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 81f08226f62627bf44423c633493538fcf5de45e
ql/src/test/results/clientpositive/quotedid_basic.q.out 7e25f38dae248d8145d51fba00df5344c37d1f6d
ql/src/test/results/clientpositive/semijoin.q.out e9ed9d7dfa3d68362ddcb170e2535b30eb82f717
ql/src/test/results/clientpositive/subquery_notin_having.q.out d073f729d0d6a34c2de9c785418899950a57ab4c
ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 3a2669b3e88bdce8f1ca458bc878563876b48041
ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 173f678d5f9275ea852dcfecd37aa14f3ef7b22b
ql/src/test/results/clientpositive/union_remove_13.q.out 47d1f23824cf619453c852ecbbd2ea41455557f8
ql/src/test/results/clientpositive/union_remove_19.q.out 92b376f61f77b23ef9735356e300f9586c65deef
ql/src/test/results/clientpositive/windowing.q.out 965438f63a4750f4abe2e06071ec39e65e53aaca
Diff: https://reviews.apache.org/r/28285/diff/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 28285: HIVE-8435
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28285/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 11:23 a.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Now SelStarNoCompute is checked in the configuration, as the field SelStarNoCompute in the operator is not initialized till initializeOp method is called. I also added an additional check on the length of colList.
Summary (updated)
-----------------
HIVE-8435
Bugs: HIVE-8926
https://issues.apache.org/jira/browse/HIVE-8926
Repository: hive-git
Description (updated)
-------
HIVE-8435
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java dabe2a8d1cdf6a3b57a3fb34a9791a824e6b22e7
ql/src/test/results/clientpositive/infer_bucket_sort.q.out c72d68e075fd21a280b7fa52c529e425c686d133
ql/src/test/results/clientpositive/infer_bucket_sort_reducers_power_two.q.out ca484eb43a235d7404b7b92bf17dbda11d6b0dfc
ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 7b61904116eff9dc52beb1137fa43d3ef09d3c83
ql/src/test/results/clientpositive/multiMapJoin1.q.out 26eca26f17bfccb242c79c54732dfe3fe726aada
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 81f08226f62627bf44423c633493538fcf5de45e
ql/src/test/results/clientpositive/quotedid_basic.q.out 7e25f38dae248d8145d51fba00df5344c37d1f6d
ql/src/test/results/clientpositive/semijoin.q.out e9ed9d7dfa3d68362ddcb170e2535b30eb82f717
ql/src/test/results/clientpositive/subquery_notin_having.q.out d073f729d0d6a34c2de9c785418899950a57ab4c
ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 3a2669b3e88bdce8f1ca458bc878563876b48041
ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 173f678d5f9275ea852dcfecd37aa14f3ef7b22b
ql/src/test/results/clientpositive/union_remove_13.q.out 47d1f23824cf619453c852ecbbd2ea41455557f8
ql/src/test/results/clientpositive/union_remove_19.q.out 92b376f61f77b23ef9735356e300f9586c65deef
ql/src/test/results/clientpositive/windowing.q.out 965438f63a4750f4abe2e06071ec39e65e53aaca
Diff: https://reviews.apache.org/r/28285/diff/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 28285: HIVE-8926
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28285/
-----------------------------------------------------------
(Updated Nov. 20, 2014, 5:55 p.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-8926
https://issues.apache.org/jira/browse/HIVE-8926
Repository: hive-git
Description
-------
HIVE-8926
Added an additional check to know whether the SelectOp swaps columns.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java dabe2a8d1cdf6a3b57a3fb34a9791a824e6b22e7
ql/src/test/results/clientpositive/multiMapJoin1.q.out 26eca26f17bfccb242c79c54732dfe3fe726aada
Diff: https://reviews.apache.org/r/28285/diff/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 28285: HIVE-8926
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28285/
-----------------------------------------------------------
(Updated Nov. 20, 2014, 5:54 p.m.)
Review request for hive and Ashutosh Chauhan.
Summary (updated)
-----------------
HIVE-8926
Bugs: HIVE-8435
https://issues.apache.org/jira/browse/HIVE-8435
Repository: hive-git
Description (updated)
-------
HIVE-8926
Added an additional check to know whether the SelectOp swaps columns.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java dabe2a8d1cdf6a3b57a3fb34a9791a824e6b22e7
ql/src/test/results/clientpositive/multiMapJoin1.q.out 26eca26f17bfccb242c79c54732dfe3fe726aada
Diff: https://reviews.apache.org/r/28285/diff/
Testing
-------
Thanks,
Jesús Camacho Rodríguez