You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2022/07/06 15:03:00 UTC
[jira] [Commented] (OAK-9770) incorrect annotation on AbstractLoginModule
[ https://issues.apache.org/jira/browse/OAK-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563284#comment-17563284 ]
Konrad Windszus commented on OAK-9770:
--------------------------------------
IMHO not OAK-6036 was the backwards-incompatible change but rather the decision of the upstream product to not allowing to implement ProviderType interfaces. From an Oak perspective I agree with [~angela] that this is more a provider type than a consumer type.
> incorrect annotation on AbstractLoginModule
> -------------------------------------------
>
> Key: OAK-9770
> URL: https://issues.apache.org/jira/browse/OAK-9770
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: security-spi
> Reporter: Ruben Reusser
> Priority: Blocker
>
> AbstractLoginModule is incorrectly annotated with @ProviderType [1] as the documentation in [0] describes the class as the basic extension point for authentication and even provides an example. This is causing a backwards compatibility issue in an upstream product due to code quality scans.
> [0] https://jackrabbit.apache.org/oak/docs/security/authentication.html
> [1]https://jackrabbit.apache.org/oak/docs/apidocs/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModule.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)