You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2015/09/23 13:32:50 UTC
[GitHub] flink pull request: [FLINK-2746] [tests] Add RetryOnException anno...
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1171
[FLINK-2746] [tests] Add RetryOnException annotation for tests
This follows the same pattern as `RetryOnFailure`, but does it only for specific exceptions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink retryOnException
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1171
----
commit 04339c7458c38d1e2bed480d4fe8e18dbb69bc95
Author: Stephan Ewen <se...@apache.org>
Date: 2015-09-23T11:28:16Z
[FLINK-2746] [tests] Add RetryOnException annotation for tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2746] [tests] Add RetryOnException anno...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1171#discussion_r40194817
--- Diff: flink-core/src/test/java/org/apache/flink/testutils/junit/RetryRule.java ---
@@ -35,11 +36,11 @@
* <pre>
* public class YourTest {
*
- * {@literal@}Rule
+ * {@literal @}Rule
--- End diff --
Update: After quick chat with Ufuk, we decided to leave it as it is. The rendering seems not well defined anyways (different IDE versions / Java versions differ).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2746] [tests] Add RetryOnException anno...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1171#issuecomment-142574609
+1 great. I would change the whitespace thingy before merging though... :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2746] [tests] Add RetryOnException anno...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1171#issuecomment-142579085
Manually merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2746] [tests] Add RetryOnException anno...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/1171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2746] [tests] Add RetryOnException anno...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1171#discussion_r40194486
--- Diff: flink-core/src/test/java/org/apache/flink/testutils/junit/RetryRule.java ---
@@ -35,11 +36,11 @@
* <pre>
* public class YourTest {
*
- * {@literal@}Rule
+ * {@literal @}Rule
--- End diff --
Oh, it looked good in the JavaDoc preview...
Will change it before merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2746] [tests] Add RetryOnException anno...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1171#discussion_r40193676
--- Diff: flink-core/src/test/java/org/apache/flink/testutils/junit/RetryRule.java ---
@@ -35,11 +36,11 @@
* <pre>
* public class YourTest {
*
- * {@literal@}Rule
+ * {@literal @}Rule
--- End diff --
the whitespace results in off-by-one indentation in the generated javadocs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---