You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "sshiv012 (via GitHub)" <gi...@apache.org> on 2026/09/11 16:22:45 UTC

[PR] feat(frontend): filter console messages by type [texera]

sshiv012 opened a new pull request, #8515:
URL: https://github.com/apache/texera/pull/8515

   ### What changes were proposed in this PR?
   
   The console badges every message with its type but offers no way to act on it. A Python UDF that prints per tuple buries a single ERROR under its output, and the panel auto-scrolls, pushing it out of view.
   
   Adds a filter menu beside the settings gear: a checkbox per message type plus a select-all, and a line above the list reporting how many messages are hidden. The gear keeps the display options it already had.
   
   Each filter option carries the same badge colour as the rows it controls. Every type is visible by default, and a type the console has not seen before stays visible rather than being hidden by an unknown-type default.
   
   Both toolbar controls become buttons so the menus can be reached by keyboard — the settings gear could not be, as a bare `<a>` with no `href`. Verified by focusing the trigger and pressing Enter.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8495
   
   ### How was this PR tested?
   
   42 unit tests in `console-frame.component.spec.ts`, up from 33 before this change.
   
   Verified live against a `1-out Python UDF` emitting 23 PRINT messages, one ERROR, plus COMMAND and DEBUGGER from the debug console — unticking Print leaves the error alone at the top.
   
   The DOM tests were checked by mutation: swapping two checkbox bindings, and replacing the hidden-count interpolation with a literal, each fail a test.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_016m8VBHFdnbBvNovMonAK9t


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(frontend): filter console messages by type [texera]

Posted by "sshiv012 (via GitHub)" <gi...@apache.org>.
sshiv012 commented on PR #8515:
URL: https://github.com/apache/texera/pull/8515#issuecomment-5673218377

   /request-review @mengw15 @aglinxinyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(frontend): filter console messages by type [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8515:
URL: https://github.com/apache/texera/pull/8515#issuecomment-5637522115

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8515?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `97.91667%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 93.63%. Comparing base ([`4d7fd49`](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`00e4b92`](https://app.codecov.io/gh/apache/texera/commit/00e4b92baec82b018c26dd0f0667dd9ba4209842?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on main.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/8515?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...t-panel/console-frame/console-frame.component.html](https://app.codecov.io/gh/apache/texera/pull/8515?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fworkspace%2Fcomponent%2Fresult-panel%2Fconsole-frame%2Fconsole-frame.component.html&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC93b3Jrc3BhY2UvY29tcG9uZW50L3Jlc3VsdC1wYW5lbC9jb25zb2xlLWZyYW1lL2NvbnNvbGUtZnJhbWUuY29tcG9uZW50Lmh0bWw=) | 96.29% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/texera/pull/8515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #8515   +/-   ##
   =========================================
     Coverage     93.62%   93.63%           
     Complexity     4842     4842           
   =========================================
     Files          1211     1211           
     Lines         49991    50032   +41     
     Branches       6125     6129    +4     
   =========================================
   + Hits          46805    46846   +41     
     Misses         1675     1675           
     Partials       1511     1511           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.18% <ø> (ø)` | | Carriedforward from [4d7fd49](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [4d7fd49](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.85% <ø> (ø)` | | Carriedforward from [4d7fd49](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.14% <ø> (ø)` | | Carriedforward from [4d7fd49](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.12% <ø> (ø)` | | Carriedforward from [4d7fd49](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.65% <ø> (ø)` | | Carriedforward from [4d7fd49](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.16% <97.91%> (+<0.01%)` | :arrow_up: | |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [4d7fd49](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.41% <ø> (ø)` | | Carriedforward from [4d7fd49](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.00% <ø> (ø)` | | Carriedforward from [4d7fd49](https://app.codecov.io/gh/apache/texera/commit/4d7fd493a8f47b28cc2155bd79c946699cec89a1?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8515?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(frontend): filter console messages by type [texera]

Posted by "sshiv012 (via GitHub)" <gi...@apache.org>.
sshiv012 commented on PR #8515:
URL: https://github.com/apache/texera/pull/8515#issuecomment-5736602460

   @aglinxinyuan can you please merge this when you find sometime? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(frontend): filter console messages by type [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8515:
URL: https://github.com/apache/texera/pull/8515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(frontend): filter console messages by type [texera]

Posted by "sshiv012 (via GitHub)" <gi...@apache.org>.
sshiv012 commented on PR #8515:
URL: https://github.com/apache/texera/pull/8515#issuecomment-5708149474

   Here are some screenshots
   <img width="817" height="467" alt="image" src="https://github.com/user-attachments/assets/6b3601b5-f81b-4581-9f42-44e87724d5b2" />
   <img width="817" height="467" alt="image" src="https://github.com/user-attachments/assets/ac414115-6e5f-4571-9509-342a53b2f974" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(frontend): filter console messages by type [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8515:
URL: https://github.com/apache/texera/pull/8515#issuecomment-5637433562

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - **Contributors with relevant context:** `@aglinxinyuan`, `@kunwp1`, `@Yicong-Huang`
     You can notify them by mentioning `@aglinxinyuan`, `@kunwp1`, `@Yicong-Huang` in a comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org