[jira] [Commented] (AIRFLOW-6654) AWS DataSync - bugfix when creating locations

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024939#comment-17024939 ] 

ASF GitHub Bot commented on AIRFLOW-6654:
-----------------------------------------

baolsen commented on pull request #7270: [AIRFLOW-6654] AWS DataSync - bugfix when creating locations
URL: https://github.com/apache/airflow/pull/7270
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> AWS DataSync - bugfix when creating locations
> ---------------------------------------------
>
>                 Key: AIRFLOW-6654
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6654
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: aws
>    Affects Versions: 1.10.7
>            Reporter: Bjorn Olsen
>            Assignee: Bjorn Olsen
>            Priority: Minor
>
> If a Location does not exist it will attempt to be created, when creating an AWS Datasync task. However this should only happen if the appropriate create_kwargs where provided - otherwise creation should not be attempted and instead an error should be produced.
>  
> This is currently not happening, below log indicates a source location was missing and DataSync operator tried to create it. However no kwargs were provided so instead it should just immediately fail.
> The log message is also a bit hard to understand and can be improved.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)