You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mindlesscloud (via GitHub)" <gi...@apache.org> on 2023/08/03 13:23:27 UTC
[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #5805: fix: fix test connection timeout and remote api error
mindlesscloud opened a new pull request, #5805:
URL: https://github.com/apache/incubator-devlake/pull/5805
### Summary
- support set timeout on testing db connection
- fix the remote API JSON parsing error by removing the field `TotalReal` from the model `ZentaoProject`
### Does this close any open issues?
Closes #5804
### Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #5805: fix: fix test connection timeout and remote api error
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #5805:
URL: https://github.com/apache/incubator-devlake/pull/5805#discussion_r1283248254
##########
backend/plugins/zentao/models/project.go:
##########
@@ -93,8 +93,8 @@ type ZentaoProject struct {
TotalConsumed float64 `json:"totalConsumed" mapstructure:"totalConsumed"`
TotalLeft float64 `json:"totalLeft" mapstructure:"totalLeft"`
Progress float64 `json:"progress" mapstructure:"progress"`
- TotalReal int `json:"totalReal" mapstructure:"totalReal"`
- ScopeConfigId uint64 `json:"scopeConfigId,omitempty" mapstructure:"scopeConfigId"`
+ //TotalReal int `json:"totalReal" mapstructure:"totalReal"`
Review Comment:
please delete it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn merged pull request #5805: fix: fix test connection timeout and remote api error
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #5805:
URL: https://github.com/apache/incubator-devlake/pull/5805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org