[GitHub] [beam] echauchot commented on a change in pull request #11578: [BEAM-8025] Increase the number of retrials and retrial delay in case of load in CassandraIOTest

[GitBox <gi...@apache.org>]

echauchot commented on a change in pull request #11578:
URL: https://github.com/apache/beam/pull/11578#discussion_r419272092



##########
File path: sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##########
@@ -153,18 +153,22 @@ public static void beforeClass() throws Exception {
 
   private static Cluster buildCluster(CassandraEmbeddedServerBuilder builder) {
     int tried = 0;
-    while (tried < 3) {
+    int delay = 5000;
+    while (tried < 5) {
       try {
         return builder.buildNativeCluster();
       } catch (NoHostAvailableException e) {

Review comment:
       The Exception is thrown by _ControlConnection.reconnectInternal()_ in the datastax driver component. It is thrown when the client has tried to connect to all newly created cassandra nodes. I'm not sure that all types of exceptions are suited for retrial upon load hence this single catch. WDYT ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org