You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/08 15:52:12 UTC
[jira] [Commented] (STORM-762) uptime for worker heartbeats is lost
when converted to thrift
[ https://issues.apache.org/jira/browse/STORM-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485257#comment-14485257 ]
ASF GitHub Bot commented on STORM-762:
--------------------------------------
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/515
STORM-762: uptime for worker heartbeats is lost when converted to thrift
I made uptime_secs required because this is a bug where falling back to broken behavior does not feel right, and the current code has not been officially released yet. If you want me to make it able to do a rolling upgrade I can without too much difficulty.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-762
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/515.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #515
----
commit 0e9cccddeebacc42995da37bb03232867e704542
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2015-04-08T13:46:32Z
STORM-762: uptime for worker heartbeats is lost when converted to thrift
----
> uptime for worker heartbeats is lost when converted to thrift
> -------------------------------------------------------------
>
> Key: STORM-762
> URL: https://issues.apache.org/jira/browse/STORM-762
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.11.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Priority: Blocker
>
> The uptime for the worker heartbeat is lost when converted to thrift. The calculation for the uptime when it is converted back from thrift is wrong, and is actually how old the heartbeat is, not the uptime of the worker.
> I'll try to throw up a patch for this tomorrow, but if someone else wants to try before then I am fine with that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)