You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2014/04/24 06:40:09 UTC

Review Request 20649: Updated mesos-style.py with already-passing rules

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20649/
-----------------------------------------------------------

Review request for mesos, Dominic Hamon and Vinod Kone.


Bugs: MESOS-1181
    https://issues.apache.org/jira/browse/MESOS-1181


Repository: mesos-git


Description
-------

Updated mesos-style.py to include useful style rules that already pass.
See https://reviews.apache.org/r/19775/ for discussion.


Diffs
-----

  support/mesos-style.py edd41f9 

Diff: https://reviews.apache.org/r/20649/diff/


Testing
-------

$ support/mesos-style.py 
Checking 414 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/tab,+whitespace/todo
Total errors found: 0


Thanks,

Adam B


Re: Review Request 20649: Updated mesos-style.py with already-passing rules

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20649/#review41269
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On April 24, 2014, 4:40 a.m., Adam B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20649/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 4:40 a.m.)
> 
> 
> Review request for mesos, Dominic Hamon and Vinod Kone.
> 
> 
> Bugs: MESOS-1181
>     https://issues.apache.org/jira/browse/MESOS-1181
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Updated mesos-style.py to include useful style rules that already pass.
> See https://reviews.apache.org/r/19775/ for discussion.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py edd41f9 
> 
> Diff: https://reviews.apache.org/r/20649/diff/
> 
> 
> Testing
> -------
> 
> $ support/mesos-style.py 
> Checking 414 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/tab,+whitespace/todo
> Total errors found: 0
> 
> 
> Thanks,
> 
> Adam B
> 
>