You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "gurpartap3697 (via GitHub)" <gi...@apache.org> on 2026/04/01 16:41:35 UTC

[PR] Fix flakiness in AdvisoryViaNetworkTest by verifying peer broker info on both sides of duplex network [activemq]

gurpartap3697 opened a new pull request, #1867:
URL: https://github.com/apache/activemq/pull/1867

   ### Problem
   AdvisoryViaNetworkTest was intermittently failing with errors like:
   
   ```
   Consumer on B for topic://A.FOO
   ```
   ref- https://github.com/apache/activemq/actions/runs/23815739249/job/69531878381?pr=1863
   
   The failure occurs in `waitForConsumerOnBroker`, indicating that broker B has not yet fully received advisory information about consumers from broker A.
   
   ### Root Cause
   The tests only verified peer broker discovery on broker A. In a duplex network, advisory propagation and peer discovery are bidirectional, but the test did not ensure that broker B had completed initialization and discovered its peer. As a result tests could proceed before broker B was fully ready or leading to race conditions and intermittent failures.
   
   ### Fix
   Added verification of peer broker info on both brokers after startup for duplex network of brokers. This ensures both sides of the duplex network are fully established before test actions begin.
   
   ### Testing
   
   Ran `AdvisoryViaNetworkTest` 30 times locally; 100% pass rate after the fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] Fix flakiness in AdvisoryViaNetworkTest by verifying peer broker info on both sides of duplex network [activemq]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1867:
URL: https://github.com/apache/activemq/pull/1867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact