You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/15 06:42:34 UTC

[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request #14912: Add fp16 and fp64 support for topk

sxjscience commented on a change in pull request #14912: Add fp16 and fp64 support for topk
URL: https://github.com/apache/incubator-mxnet/pull/14912#discussion_r284106072
 
 

 ##########
 File path: src/operator/tensor/ordering_op-inl.h
 ##########
 @@ -401,8 +401,6 @@ void TopKImpl(const RunContext &ctx,
     mxnet::op::SortByKeyWorkspaceSize<int, int, xpu>(src.Size()));
   temp_size = std::max(temp_size,
     mxnet::op::SortByKeyWorkspaceSize<int, DType, xpu>(src.Size()));
-  temp_size = std::max(temp_size,
-    mxnet::op::SortByKeyWorkspaceSize<DType, int, xpu>(src.Size()));
 
 Review comment:
   This line should be useful because we need to do `mxnet::op::SortByKey(dat, ind, is_ascend, &sort_work);`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services