You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/02 16:46:35 UTC

[GitHub] [superset] codecov-io commented on pull request #12894: chore: remove SIP-38 feature flag

codecov-io commented on pull request #12894:
URL: https://github.com/apache/superset/pull/12894#issuecomment-771777520


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=h1) Report
   > Merging [#12894](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=desc) (63fe77b) into [master](https://codecov.io/gh/apache/superset/commit/9cc38ac1d93a44925d9cd8dcc49fb2a204ef7308?el=desc) (9cc38ac) will **decrease** coverage by `1.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12894/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12894      +/-   ##
   ==========================================
   - Coverage   63.21%   61.84%   -1.37%     
   ==========================================
     Files        1025      535     -490     
     Lines       50291    20045   -30246     
     Branches     5241     5241              
   ==========================================
   - Hits        31790    12397   -19393     
   + Misses      18289     7436   -10853     
     Partials      212      212              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `61.84% <ø> (ø)` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/utils/async\_query\_manager.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvYXN5bmNfcXVlcnlfbWFuYWdlci5weQ==) | | |
   | [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | | |
   | [superset/reports/notifications/exceptions.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2V4Y2VwdGlvbnMucHk=) | | |
   | [...versions/bb51420eaf83\_add\_schema\_to\_table\_model.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iYjUxNDIwZWFmODNfYWRkX3NjaGVtYV90b190YWJsZV9tb2RlbC5weQ==) | | |
   | [superset/migrations/versions/472d2f73dfd4\_.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NzJkMmY3M2RmZDRfLnB5) | | |
   | [superset/examples/sf\_population\_polygons.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvc2ZfcG9wdWxhdGlvbl9wb2x5Z29ucy5weQ==) | | |
   | [...ab3d66c4246e\_add\_cache\_timeout\_to\_druid\_cluster.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjNkNjZjNDI0NmVfYWRkX2NhY2hlX3RpbWVvdXRfdG9fZHJ1aWRfY2x1c3Rlci5weQ==) | | |
   | [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | | |
   | [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | | |
   | [...ns/versions/b5998378c225\_add\_certificate\_to\_dbs.py](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iNTk5ODM3OGMyMjVfYWRkX2NlcnRpZmljYXRlX3RvX2Ricy5weQ==) | | |
   | ... and [473 more](https://codecov.io/gh/apache/superset/pull/12894/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=footer). Last update [9cc38ac...63fe77b](https://codecov.io/gh/apache/superset/pull/12894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org