[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics

[GitBox <gi...@apache.org>]

EricGao888 commented on code in PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#discussion_r898921559


##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/metrics/WorkerServerMetrics.java:
##########
@@ -30,13 +30,13 @@ public WorkerServerMetrics() {
     }
 
     private static final Counter WORKER_OVERLOAD_COUNTER =
-            Counter.builder("dolphinscheduler_worker_overload_count")
-                    .description("worker load count")
+            Counter.builder("ds.system.worker.overload.count")
+                    .description("overloaded workers count")
                     .register(Metrics.globalRegistry);
 
     private static final Counter WORKER_SUBMIT_QUEUE_IS_FULL_COUNTER =
-            Counter.builder("dolphinscheduler_worker_submit_queue_is_full_count")
-                    .description("worker task submit queue is full count")
+            Counter.builder("ds.system.worker.full.submit.queue.count")

Review Comment:
   Sure, will remove `system`, since it might cause some ambiguities with jvm / network level stuff.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org