You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thomas Koch (Created) (JIRA)" <ji...@apache.org> on 2011/11/03 10:35:32 UTC
[jira] [Created] (ZOOKEEPER-1284) Cleanup minor
PrepRequestProcessor issues
Cleanup minor PrepRequestProcessor issues
-----------------------------------------
Key: ZOOKEEPER-1284
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1284
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Thomas Koch
Assignee: Thomas Koch
Priority: Minor
Instead of having if statements in every switch case in pRequest2Txn, it is possible to have only one if statement before the switch case in pRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1284) Cleanup minor
PrepRequestProcessor issues
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143010#comment-13143010 ]
Hadoop QA commented on ZOOKEEPER-1284:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12502121/ZOOKEEPER-1284.patch
against trunk revision 1196819.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/772//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/772//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/772//console
This message is automatically generated.
> Cleanup minor PrepRequestProcessor issues
> -----------------------------------------
>
> Key: ZOOKEEPER-1284
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1284
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1284.patch
>
>
> Instead of having if statements in every switch case in pRequest2Txn, it is possible to have only one if statement before the switch case in pRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1284) Cleanup minor
PrepRequestProcessor issues
Posted by "Thomas Koch (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143024#comment-13143024 ]
Thomas Koch commented on ZOOKEEPER-1284:
----------------------------------------
The only failed unit test in the last jenkins run is our good friend "org.apache.zookeeper.test.ObserverTest.testObserver". He fails from time to time on any patch you throw on it.
> Cleanup minor PrepRequestProcessor issues
> -----------------------------------------
>
> Key: ZOOKEEPER-1284
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1284
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1284.patch
>
>
> Instead of having if statements in every switch case in pRequest2Txn, it is possible to have only one if statement before the switch case in pRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1284) Cleanup minor
PrepRequestProcessor issues
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143027#comment-13143027 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1284:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2671/
-----------------------------------------------------------
(Updated 2011-11-03 10:12:51.768461)
Review request for zookeeper.
Changes
-------
Changed this review request to relate to issue ZOOKEEPER-1284
Summary (updated)
-------
This is _not_ a diff againt current trunk but against the trunk _before_ the first version of the ZK-1246 patch got committed.
This addresses bug ZOOKEEPER-1284.
https://issues.apache.org/jira/browse/ZOOKEEPER-1284
Diffs
-----
CHANGES.txt 8ed2bc2
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1a80d74
src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/2671/diff
Testing
-------
Thanks,
Thomas
> Cleanup minor PrepRequestProcessor issues
> -----------------------------------------
>
> Key: ZOOKEEPER-1284
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1284
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1284.patch
>
>
> Instead of having if statements in every switch case in pRequest2Txn, it is possible to have only one if statement before the switch case in pRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1284) Cleanup minor
PrepRequestProcessor issues
Posted by "Thomas Koch (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1284:
-----------------------------------
Attachment: ZOOKEEPER-1284.patch
> Cleanup minor PrepRequestProcessor issues
> -----------------------------------------
>
> Key: ZOOKEEPER-1284
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1284
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1284.patch
>
>
> Instead of having if statements in every switch case in pRequest2Txn, it is possible to have only one if statement before the switch case in pRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira