You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Charles Chen <ch...@fb.com> on 2011/08/03 03:20:49 UTC
Review Request: HIVE-2337: Predicate pushdown erroneously conservative with
outer joins
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/
-----------------------------------------------------------
Review request for hive.
Summary
-------
Initial patch
This addresses bug HIVE-2337.
https://issues.apache.org/jira/browse/HIVE-2337
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1153293
Diff: https://reviews.apache.org/r/1275/diff
Testing
-------
Thanks,
Charles
Re: Review Request: HIVE-2337: Predicate pushdown erroneously conservative
with outer joins
Posted by John Sichi <js...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/#review1710
-----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java
<https://reviews.apache.org/r/1275/#comment3884>
There is a weird non-ASCII character on this line.
- John
On 2011-09-01 00:19:17, Charles Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1275/
> -----------------------------------------------------------
>
> (Updated 2011-09-01 00:19:17)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/HIVE-2337
>
>
> This addresses bug HIVE-2337.
> https://issues.apache.org/jira/browse/HIVE-2337
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1163875
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join4.q.out 1163875
>
> Diff: https://reviews.apache.org/r/1275/diff
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: HIVE-2337: Predicate pushdown erroneously conservative
with outer joins
Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/
-----------------------------------------------------------
(Updated 2011-09-01 04:42:25.815081)
Review request for hive.
Changes
-------
Added TestParse changes ??
Summary
-------
https://issues.apache.org/jira/browse/HIVE-2337
This addresses bug HIVE-2337.
https://issues.apache.org/jira/browse/HIVE-2337
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1163875
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/ppd_outer_join5.q PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join4.q.out 1163875
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join5.q.out PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/compiler/plan/input4.q.xml 1163875
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/compiler/plan/join8.q.xml 1163875
Diff: https://reviews.apache.org/r/1275/diff
Testing
-------
Unit tests passed
Thanks,
Charles
Re: Review Request: HIVE-2337: Predicate pushdown erroneously conservative
with outer joins
Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/
-----------------------------------------------------------
(Updated 2011-09-01 04:26:59.076177)
Review request for hive.
Changes
-------
Oops fixed dropped unit test, javadoc character
Summary
-------
https://issues.apache.org/jira/browse/HIVE-2337
This addresses bug HIVE-2337.
https://issues.apache.org/jira/browse/HIVE-2337
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join5.q.out PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1163875
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/ppd_outer_join5.q PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join4.q.out 1163875
Diff: https://reviews.apache.org/r/1275/diff
Testing
-------
Unit tests passed
Thanks,
Charles
Re: Review Request: HIVE-2337: Predicate pushdown erroneously conservative
with outer joins
Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/
-----------------------------------------------------------
(Updated 2011-09-01 00:19:17.176704)
Review request for hive.
Changes
-------
Rebased to current trunk
Summary
-------
https://issues.apache.org/jira/browse/HIVE-2337
This addresses bug HIVE-2337.
https://issues.apache.org/jira/browse/HIVE-2337
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1163875
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join4.q.out 1163875
Diff: https://reviews.apache.org/r/1275/diff
Testing
-------
Unit tests passed
Thanks,
Charles
Re: Review Request: HIVE-2337: Predicate pushdown erroneously conservative
with outer joins
Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/
-----------------------------------------------------------
(Updated 2011-09-01 00:08:37.474019)
Review request for hive.
Changes
-------
Fixed ppd_outer_join4.q.out
Summary
-------
https://issues.apache.org/jira/browse/HIVE-2337
This addresses bug HIVE-2337.
https://issues.apache.org/jira/browse/HIVE-2337
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1163856
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/ppd_outer_join5.q PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join4.q.out 1163856
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join5.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1275/diff
Testing
-------
Unit tests passed
Thanks,
Charles
Re: Review Request: HIVE-2337: Predicate pushdown erroneously conservative
with outer joins
Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/
-----------------------------------------------------------
(Updated 2011-08-09 17:41:41.427733)
Review request for hive.
Changes
-------
Unit tests passed
Summary
-------
https://issues.apache.org/jira/browse/HIVE-2337
This addresses bug HIVE-2337.
https://issues.apache.org/jira/browse/HIVE-2337
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1153598
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/ppd_outer_join5.q PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join5.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1275/diff
Testing (updated)
-------
Unit tests passed
Thanks,
Charles
Re: Review Request: HIVE-2337: Predicate pushdown erroneously conservative
with outer joins
Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/
-----------------------------------------------------------
(Updated 2011-08-03 21:13:25.076077)
Review request for hive.
Changes
-------
Fix testcase
Summary
-------
https://issues.apache.org/jira/browse/HIVE-2337
This addresses bug HIVE-2337.
https://issues.apache.org/jira/browse/HIVE-2337
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1153598
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/ppd_outer_join5.q PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join5.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1275/diff
Testing
-------
Thanks,
Charles
Re: Review Request: HIVE-2337: Predicate pushdown erroneously conservative
with outer joins
Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/
-----------------------------------------------------------
(Updated 2011-08-03 21:03:23.393902)
Review request for hive.
Summary (updated)
-------
https://issues.apache.org/jira/browse/HIVE-2337
This addresses bug HIVE-2337.
https://issues.apache.org/jira/browse/HIVE-2337
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1153598
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join5.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1275/diff
Testing
-------
Thanks,
Charles
Re: Review Request: HIVE-2337: Predicate pushdown erroneously conservative
with outer joins
Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1275/
-----------------------------------------------------------
(Updated 2011-08-03 21:02:11.625203)
Review request for hive.
Changes
-------
Added test cases, fixed comment
Summary
-------
Initial patch
This addresses bug HIVE-2337.
https://issues.apache.org/jira/browse/HIVE-2337
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1153598
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join5.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1275/diff
Testing
-------
Thanks,
Charles