You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/08/15 08:04:05 UTC
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7853: Fix role escalation prevention
weizhouapache commented on code in PR #7853:
URL: https://github.com/apache/cloudstack/pull/7853#discussion_r1294304022
##########
plugins/acl/static-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java:
##########
@@ -107,6 +107,10 @@ public boolean checkAccess(User user, String commandName) throws PermissionDenie
@Override
public boolean checkAccess(Account account, String commandName) {
+ if (isEnabled()) {
+ return true;
+ }
Review Comment:
yes, it looks like a bug @DaanHoogland
we should change the return value of `isEnabled` in this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org