You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/12 18:43:41 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #10491: [FLINK-15093][streaming-java] StreamExecutionEnvironment does not cle…

tillrohrmann commented on a change in pull request #10491: [FLINK-15093][streaming-java] StreamExecutionEnvironment does not cle…
URL: https://github.com/apache/flink/pull/10491#discussion_r357308242
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/LocalStreamEnvironment.java
 ##########
 @@ -68,19 +66,4 @@ private static Configuration validateAndGetConfiguration(final Configuration con
 		effectiveConfiguration.set(DeploymentOptions.ATTACHED, true);
 		return effectiveConfiguration;
 	}
-
-	/**
-	 * Executes the JobGraph of the on a mini cluster of ClusterUtil with a user
-	 * specified name.
-	 *
-	 * @return The result of the job execution, containing elapsed time and accumulators.
-	 */
-	@Override
-	public JobExecutionResult execute(StreamGraph streamGraph) throws Exception {
-		try {
-			return super.execute(streamGraph);
-		} finally {
-			transformations.clear();
-		}
-	}
 
 Review comment:
   I think the removal of this method makes the japicmp plugin to fail: https://travis-ci.org/apache/flink/jobs/624197613
   
   ```
   17:06:02.660 [ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project flink-streaming-java_2.11: Breaking the build because there is at least one incompatibility: org.apache.flink.streaming.api.environment.LocalStreamEnvironment.execute(org.apache.flink.streaming.api.graph.StreamGraph):METHOD_REMOVED -> [Help 1]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services