You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2021/01/25 10:24:09 UTC

[GitHub] [ambari] dvitiiuk opened a new pull request #3280: AMBARI-25612. Ambari stops alert notices dispatching on unhandled exception inside.

dvitiiuk opened a new pull request #3280:
URL: https://github.com/apache/ambari/pull/3280


   ## What changes were proposed in this pull request?
   
   Now AlertNoticeDispatchService.runOneIteration() continue notices dispatching ever after errors with DB connection.
   
   ## How was this patch tested?
   
   Manual testing with raised DB connection issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] hapylestat merged pull request #3280: AMBARI-25612. Ambari stops alert notices dispatching on unhandled exception inside.

Posted by GitBox <gi...@apache.org>.
hapylestat merged pull request #3280:
URL: https://github.com/apache/ambari/pull/3280


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] dvitiiuk commented on pull request #3280: AMBARI-25612. Ambari stops alert notices dispatching on unhandled exception inside.

Posted by GitBox <gi...@apache.org>.
dvitiiuk commented on pull request #3280:
URL: https://github.com/apache/ambari/pull/3280#issuecomment-766791419


   > how about adding more granular try-catch sections?
   > Looks like we already have `try-catch(exception)` sections inside. These sections be just extended instead of adding yet another try-catch on top of them?
   
   I divided "runOneIteration" method to couple separated + wrapped with new try-catch only code which retrieves notices.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] dvitiiuk commented on pull request #3280: AMBARI-25612. Ambari stops alert notices dispatching on unhandled exception inside.

Posted by GitBox <gi...@apache.org>.
dvitiiuk commented on pull request #3280:
URL: https://github.com/apache/ambari/pull/3280#issuecomment-766791419


   > how about adding more granular try-catch sections?
   > Looks like we already have `try-catch(exception)` sections inside. These sections be just extended instead of adding yet another try-catch on top of them?
   
   I divided "runOneIteration" method to couple separated + wrapped with new try-catch only code which retrieves notices.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org