You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jayeshchoudhary (via GitHub)" <gi...@apache.org> on 2024/02/13 15:56:24 UTC
[PR] UI: add preferred node version, ignore prettier formatting [pinot]
jayeshchoudhary opened a new pull request, #12409:
URL: https://github.com/apache/pinot/pull/12409
This is `ui`, `chore`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] UI: add preferred node version, ignore prettier formatting [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary closed pull request #12409: UI: add preferred node version, ignore prettier formatting
URL: https://github.com/apache/pinot/pull/12409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] UI: add preferred node version, ignore prettier formatting [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on code in PR #12409:
URL: https://github.com/apache/pinot/pull/12409#discussion_r1493822134
##########
pinot-controller/src/main/resources/.prettierignore:
##########
@@ -0,0 +1 @@
+*
Review Comment:
I will write prettier and eslint configs properly for this project.
That will be in a separate PR, until then this should be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] UI: add preferred node version, ignore prettier formatting [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on PR #12409:
URL: https://github.com/apache/pinot/pull/12409#issuecomment-1946862402
@saurabhd336 @jadami10 please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] UI: add preferred node version, ignore prettier formatting [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on PR #12409:
URL: https://github.com/apache/pinot/pull/12409#issuecomment-1946864418
does it make sense to link this doc in the home readme?
here? - https://github.com/apache/pinot?tab=readme-ov-file#building-pinot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] UI: add preferred node version, ignore prettier formatting [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on PR #12409:
URL: https://github.com/apache/pinot/pull/12409#issuecomment-2053732424
addressed here
https://github.com/apache/pinot/pull/12924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] UI: add preferred node version, ignore prettier formatting [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on PR #12409:
URL: https://github.com/apache/pinot/pull/12409#issuecomment-1946874346
@saurabhd336 @jadami10 please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] UI: add preferred node version, ignore prettier formatting [pinot]
Posted by "jadami10 (via GitHub)" <gi...@apache.org>.
jadami10 commented on code in PR #12409:
URL: https://github.com/apache/pinot/pull/12409#discussion_r1492031199
##########
pinot-controller/src/main/resources/.prettierignore:
##########
@@ -0,0 +1 @@
+*
Review Comment:
what's the reasoning here? If anything I was hoping we'd start enforcing prettier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] UI: add preferred node version, ignore prettier formatting [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #12409:
URL: https://github.com/apache/pinot/pull/12409#issuecomment-1958857654
Can you please take a look at the failed tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org