You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2012/11/03 03:34:19 UTC
svn commit: r1405265 -
/maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java
Author: hboutemy
Date: Sat Nov 3 02:34:18 2012
New Revision: 1405265
URL: http://svn.apache.org/viewvc?rev=1405265&view=rev
Log:
closed streams
Modified:
maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java
Modified: maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java?rev=1405265&r1=1405264&r2=1405265&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java Sat Nov 3 02:34:18 2012
@@ -189,13 +189,20 @@ public class PluginHelpGenerator
properties.put( "artifactId", pluginDescriptor.getArtifactId() );
properties.put( "goalPrefix", pluginDescriptor.getGoalPrefix() );
- // FIXME encoding !
-
StringWriter stringWriter = new StringWriter();
InputStream is = Thread.currentThread().getContextClassLoader().getResourceAsStream( "help-class-source.vm" );
- InputStreamReader isReader = new InputStreamReader( is ); // FIXME platform encoding
- velocityComponent.getEngine().evaluate( context, stringWriter, "", isReader ); // FIXME close reader
+ InputStreamReader isReader = null;
+ try
+ {
+ isReader = new InputStreamReader( is ); // FIXME platform encoding
+ velocityComponent.getEngine().evaluate( context, stringWriter, "", isReader );
+ }
+ finally
+ {
+ IOUtil.close( is );
+ IOUtil.close( isReader );
+ }
return stringWriter.toString();
}