[GitHub] [pulsar] sijie commented on a change in pull request #4923: [Transaction][buffer] create a commit marker at topic ledger

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #4923: [Transaction][buffer] create a commit marker at topic ledger
URL: https://github.com/apache/pulsar/pull/4923#discussion_r312684610
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
 ##########
 @@ -1533,4 +1535,49 @@ public boolean isBatchMessageCompatibleVersion() {
     public String getClientVersion() {
         return clientVersion;
     }
+
+    /**
+     * The transaction marker controller controls the commit marker or the abort marker publish to the specified topic.
+     * If it is a commit marker, we need to wait for the position it committed at the topic.
+     */
+    final static class TxnMarkerController implements Topic.PublishContext {
 
 Review comment:
   it is unclear how this `PublishContext` is used for committing the transaction and how it interacts with transaction buffer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services