You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yahoNanJing (via GitHub)" <gi...@apache.org> on 2023/06/28 13:13:08 UTC
[GitHub] [arrow-ballista] yahoNanJing opened a new pull request, #823: Remove ExecutorReservation and change the task assignment philosophy from executor first to task first
yahoNanJing opened a new pull request, #823:
URL: https://github.com/apache/arrow-ballista/pull/823
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #708.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing merged pull request #823: Remove ExecutorReservation and change the task assignment philosophy from executor first to task first
Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing merged PR #823:
URL: https://github.com/apache/arrow-ballista/pull/823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #823: Remove ExecutorReservation and change the task assignment philosophy from executor first to task first
Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #823:
URL: https://github.com/apache/arrow-ballista/pull/823#issuecomment-1617126925
Thanks @thinkharderdev for your comments.
> I'm still a little confused as to why this is required to enable caching.
For consistent hashing based task assignment, we should do the task assignment based on the scan files of the task if there is. The details is described in #833. This means it's necessary to assign a specific executor for a task rather than assign a random task for an executor.
> The original goal of the ExecutorReservation was to minimize contention on the task slots state.
I totally understand the purpose of `ExecutorReservation`. However, for the current implementation, it actually does not reduce the contention too much. https://github.com/apache/arrow-ballista/blob/b65464e4b73590470fa69aad5b6954300ad243a0/ballista/scheduler/src/state/mod.rs#L190-L228
From the above code, if there are still some pending tasks, it will still go to invoke `reserve_slots`.
To reduce the resource contention or lock contention, based on this PR, I'll raise another PR to refactor the event processing to introduce batch event processing. For example, to combine 10 task status update event to one so that only one resource contention will be involved. Sample code can be found [here](https://github.com/yahoNanJing/arrow-ballista/blob/dev-20230510/ballista/scheduler/src/state/event_action.rs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #823: Remove ExecutorReservation and change the task assignment philosophy from executor first to task first
Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #823:
URL: https://github.com/apache/arrow-ballista/pull/823#issuecomment-1628672288
Since this PR has been under review for half a month, if there's no opposite options, I'll merge this in next a few days so that the data cache related PRs can go on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #823: Remove ExecutorReservation and change the task assignment philosophy from executor first to task first
Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #823:
URL: https://github.com/apache/arrow-ballista/pull/823#issuecomment-1611431992
Hi @thinkharderdev and @Dandandan, could you help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] collimarco commented on pull request #823: Remove ExecutorReservation and change the task assignment philosophy from executor first to task first
Posted by "collimarco (via GitHub)" <gi...@apache.org>.
collimarco commented on PR #823:
URL: https://github.com/apache/arrow-ballista/pull/823#issuecomment-1612804267
+1 for merging this, so that it enables the implementation of this major feature: https://github.com/apache/arrow-ballista/issues/645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org