You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/24 18:09:13 UTC

[GitHub] [spark] gengliangwang commented on a diff in pull request #37632: [SPARK-40197][SQL] Replace query plan with context for MULTI_VALUE_SUBQUERY_ERROR

gengliangwang commented on code in PR #37632:
URL: https://github.com/apache/spark/pull/37632#discussion_r954128592


##########
core/src/main/scala/org/apache/spark/SparkException.scala:
##########
@@ -29,7 +29,8 @@ class SparkException(
     cause: Throwable,
     errorClass: Option[String],
     errorSubClass: Option[String],
-    messageParameters: Array[String])
+    messageParameters: Array[String],
+    context: Array[QueryContext] = Array.empty)

Review Comment:
   @MaxGekk As you mentioned, you plan to add context in `SparkException`. Is this part looking good to you?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org