[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

[GitBox <gi...@apache.org>]

ChrisSamo632 commented on code in PR #6806:
URL: https://github.com/apache/nifi/pull/6806#discussion_r1058903579


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-utils/src/test/java/org/apache/nifi/nar/NarThreadContextClassLoaderTest.java:
##########
@@ -63,16 +63,12 @@ public void validateWithDefaultConstructor() throws Exception {
         Bundle systemBundle = SystemBundle.create(properties);
         ExtensionDiscoveringManager extensionManager = new StandardExtensionDiscoveringManager();
         extensionManager.discoverExtensions(systemBundle, Collections.emptySet());
-        assertTrue(NarThreadContextClassLoader.createInstance(extensionManager, WithDefaultConstructor.class.getName(),
-                WithDefaultConstructor.class, properties) instanceof WithDefaultConstructor);
+        assertNotNull(NarThreadContextClassLoader.createInstance(extensionManager, WithDefaultConstructor.class.getName(),

Review Comment:
   ```suggestion
           assertInstanceOf(WithDefaultConstructor.class, NarThreadContextClassLoader.createInstance(extensionManager, WithDefaultConstructor.class.getName(),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org