You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/24 12:55:52 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1293: sim: fix compile error caused by race condition

Ouss4 commented on a change in pull request #1293:
URL: https://github.com/apache/incubator-nuttx/pull/1293#discussion_r444871961



##########
File path: arch/sim/src/Makefile
##########
@@ -316,7 +316,8 @@ export_startup: board/libboard$(LIBEXT) up_head.o $(HOSTOBJS)
 depend: .depend
 
 cleanrel:
-	$(Q) rm -f nuttx.rel nuttx-names.dat
+	$(call DELFILE, nuttx-names.dat)
+	$(call DELFILE, nuttx.rel)

Review comment:
       Would this fix a race condition issue?
   This change is okay by itself, but I don't see how it addresses a race condition. 
   Isn't line 293 that can cause such a problem?
   https://github.com/apache/incubator-nuttx/blob/d6a0da41d55d342aa5b434b98282c76cd996f1d3/arch/sim/src/Makefile#L293




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org