You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "gitgabrio (via GitHub)" <gi...@apache.org> on 2025/01/08 09:14:06 UTC

[I] DMN: B-FEEL implementation [incubator-kie-issues]

gitgabrio opened a new issue, #1742:
URL: https://github.com/apache/incubator-kie-issues/issues/1742

   Verify/implement the new B-FEEL version inside DMN.
   B-FEEL should be optionally enabled (i.e., disabled by default) setting expression language to
   
   `“https://www.omg.org/spec/DMN/20240513/B-FEEL/”`
   
   
   
   Verify the specs
   
   
   [B-FEEL - Proposal.docx](https://github.com/bamoe/private-bamoe-issues/files/15232729/B-FEEL.-.Proposal.docx)
   
   Requires 
   
   - [x] https://github.com/apache/incubator-kie-issues/issues/73
   - [x] https://github.com/apache/incubator-kie-issues/issues/1187
   - [x] https://github.com/apache/incubator-kie-issues/issues/1206
   - [x] https://github.com/apache/incubator-kie-issues/issues/1344
   
   to be fixed, before
   
   @baldimir @yesamer 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] DMN: B-FEEL implementation [incubator-kie-issues]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on issue #1742:
URL: https://github.com/apache/incubator-kie-issues/issues/1742#issuecomment-2591959000

   Further checks in the sandbox will be done as https://github.com/apache/incubator-kie-issues/issues/1751


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] DMN: B-FEEL implementation [incubator-kie-issues]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on issue #1742:
URL: https://github.com/apache/incubator-kie-issues/issues/1742#issuecomment-2579380753

   @jomarko 
   thanks for spotting that!
   So, first of all `expressionLanguage` can be overridden
   
   From [spec](https://www.omg.org/spec/DMN/1.6/Beta1/PDF):
   
   > An instance of Definitions may specify an expressionLanguage, which is a URI that identifies the
   default expression language used in elements within the scope of this Definitions. This value may be
   overridden on each individual LiteralExpression. 
   
   
   About "plain text input versus maybe dropdown of values", specs (IINW) does not provide a defined list of allowed ones, just  mention that `expressionLanguage` maybe anything in URI format (there is also a mention to XPATH 2, e.g.
   
   > An instance of LiteralExpression may include importedValues, which is an instance of a subclass
   Import that identifies where the text of the LiteralExpression is located. importedValues is an
   expression that selects text from an imported document. An instance of LiteralExpression SHALL NOT
   have both a text and importedValues. The importType of the importedValues identifies the type of
   document containing the imported text and SHALL be consistent with the expressionLanguage of the
   LiteralExpression element. The expressionLanguage of the importedValues element identifies
   how the imported text is selected from the imported document. For example, if the importType indicates an
   XML document, the expressionLanguage of importedValues could be XPATH 2.0.
   
   To sum-up, we'll need to discuss and review the implementation with @baldimir  and @yesamer, to double-check the current implementation about this detail.
   
   Thanks again!!!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] DMN: B-FEEL implementation [incubator-kie-issues]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on issue #1742:
URL: https://github.com/apache/incubator-kie-issues/issues/1742#issuecomment-2579320875

   @gitgabrio hi, I tried to check what change, if any, is needed on the Editor side and this question came to my mind. Is it valid, that more implementations can be specified in the model?
   
   In the root of the model, Editor has this:
   ![Screenshot 2025-01-09 080955](https://github.com/user-attachments/assets/471a192a-11fa-4c9b-8a10-1472eca3d350)
   
   However, we have also this on the expression cell level:
   ![Screenshot 2025-01-09 081022](https://github.com/user-attachments/assets/a8d3da59-0a7b-40f9-8707-6cdd81292267)
   
   Is a valid scenario, lets say model root set expression as FEEL and some expression cell set it as B-FEEL or vice versa?
   
   Also, I wonder what is your opinion about `Expression langugage` to be plain text input versus maybe dropdown of values?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] DMN: B-FEEL implementation [incubator-kie-issues]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio closed issue #1742: DMN: B-FEEL implementation
URL: https://github.com/apache/incubator-kie-issues/issues/1742


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org