You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/27 09:57:29 UTC
[GitHub] [airflow] potiuk opened a new pull request #7569: Airflow 6945
mysql 5 7 in airflow 1.10
potiuk opened a new pull request #7569: Airflow 6945 mysql 5 7 in airflow 1.10
URL: https://github.com/apache/airflow/pull/7569
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7569: [AIRFLOW-6945] mysql 5 7
in airflow 1.10
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7569: [AIRFLOW-6945] mysql 5 7 in airflow 1.10
URL: https://github.com/apache/airflow/pull/7569#issuecomment-598709149
Hmmmm is this "safe" to change the version requirement/what we test against in 1.10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7569: [AIRFLOW-6945] mysql
5 7 in airflow 1.10
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7569: [AIRFLOW-6945] mysql 5 7 in airflow 1.10
URL: https://github.com/apache/airflow/pull/7569#issuecomment-596228872
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=h1) Report
> Merging [#7569](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/a0ece8c86570286143012e51a9c3596f6de3ed76?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-test #7569 +/- ##
==============================================
- Coverage 81.65% 81.64% -0.01%
==============================================
Files 529 529
Lines 36453 36453
==============================================
- Hits 29764 29762 -2
- Misses 6689 6691 +2
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.1% <0%> (-0.44%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `92.16% <0%> (+0.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=footer). Last update [a0ece8c...fbf7ef7](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7569: [AIRFLOW-6945] mysql 5 7
in airflow 1.10
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7569: [AIRFLOW-6945] mysql 5 7 in airflow 1.10
URL: https://github.com/apache/airflow/pull/7569#issuecomment-599176783
Closing - as it's been cherry-picked now from master (still leaving 5.6 as majority of MySQL tests)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7569:
[AIRFLOW-6945] mysql 5 7 in airflow 1.10
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7569: [AIRFLOW-6945] mysql 5 7 in airflow 1.10
URL: https://github.com/apache/airflow/pull/7569#issuecomment-596228872
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=h1) Report
> Merging [#7569](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/a916e8c39072dce859bd864835c2d04b9eee16df&el=desc) will **decrease** coverage by `71.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-test #7569 +/- ##
===============================================
- Coverage 81.65% 10.60% -71.05%
===============================================
Files 529 528 -1
Lines 36453 36441 -12
===============================================
- Hits 29764 3864 -25900
- Misses 6689 32577 +25888
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/utils/strings.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zdHJpbmdzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/www/validators.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmFsaWRhdG9ycy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/www\_rbac/forms.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy9mb3Jtcy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/slack\_hook.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9zbGFja19ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/www\_rbac/widgets.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy93aWRnZXRzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/sqlite\_hook.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9zcWxpdGVfaG9vay5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/operators/sensors.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2Vuc29ycy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [473 more](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=footer). Last update [a916e8c...e862292](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7569: [AIRFLOW-6945] mysql 5 7
in airflow 1.10
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7569: [AIRFLOW-6945] mysql 5 7 in airflow 1.10
URL: https://github.com/apache/airflow/pull/7569#issuecomment-599039279
I will cherry-pick the "DB versions" when they are merged and will add both 5.6 and 5.7 to 1.10 builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk closed pull request #7569: [AIRFLOW-6945] mysql 5
7 in airflow 1.10
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #7569: [AIRFLOW-6945] mysql 5 7 in airflow 1.10
URL: https://github.com/apache/airflow/pull/7569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7569:
[AIRFLOW-6945] mysql 5 7 in airflow 1.10
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7569: [AIRFLOW-6945] mysql 5 7 in airflow 1.10
URL: https://github.com/apache/airflow/pull/7569#issuecomment-596228872
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=h1) Report
> Merging [#7569](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/a916e8c39072dce859bd864835c2d04b9eee16df&el=desc) will **decrease** coverage by `71.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-test #7569 +/- ##
===============================================
- Coverage 81.65% 10.60% -71.05%
===============================================
Files 529 528 -1
Lines 36453 36441 -12
===============================================
- Hits 29764 3864 -25900
- Misses 6689 32577 +25888
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/utils/strings.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zdHJpbmdzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/www/validators.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmFsaWRhdG9ycy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/www\_rbac/forms.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy9mb3Jtcy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/slack\_hook.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9zbGFja19ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/www\_rbac/widgets.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy93aWRnZXRzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/sqlite\_hook.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9zcWxpdGVfaG9vay5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/operators/sensors.py](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2Vuc29ycy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [473 more](https://codecov.io/gh/apache/airflow/pull/7569/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=footer). Last update [a916e8c...e862292](https://codecov.io/gh/apache/airflow/pull/7569?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7569: [AIRFLOW-6945] mysql 5 7
in airflow 1.10
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7569: [AIRFLOW-6945] mysql 5 7 in airflow 1.10
URL: https://github.com/apache/airflow/pull/7569#issuecomment-598746904
That's a good question. Maybe I can add both actually. We do not run it to often so maybe adding one more travis run is not a problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services