You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/10 02:47:59 UTC

[GitHub] [rocketmq] francisoliverlee commented on a change in pull request #3232: [ISSUE #3231]add topic expire time policy

francisoliverlee commented on a change in pull request #3232:
URL: https://github.com/apache/rocketmq/pull/3232#discussion_r685650699



##########
File path: common/src/main/java/org/apache/rocketmq/common/TopicConfig.java
##########
@@ -29,6 +29,7 @@
     private TopicFilterType topicFilterType = TopicFilterType.SINGLE_TAG;
     private int topicSysFlag = 0;
     private boolean order = false;
+    private Integer expirationTime;
 

Review comment:
       “expirationTime” get me confused, expirationTimeInMs can be better




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org