You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/13 06:11:26 UTC

[GitHub] [netbeans] singh-akhilesh commented on a change in pull request #2301: [NETBEANS-4681] Fixed issue : refactor record rename & move record file to other package

singh-akhilesh commented on a change in pull request #2301:
URL: https://github.com/apache/netbeans/pull/2301#discussion_r469718068



##########
File path: java/java.source.base/src/org/netbeans/api/java/source/TreeUtilities.java
##########
@@ -124,7 +125,14 @@
      * @since 0.67
      */
     public static final Set<Kind> CLASS_TREE_KINDS = EnumSet.of(Kind.ANNOTATION_TYPE, Kind.CLASS, Kind.ENUM, Kind.INTERFACE);
-    
+    static {
+        Kind recKind = null;
+        try {
+            recKind = Kind.valueOf(TreeShims.RECORD); //NOI18N

Review comment:
       comments addressed

##########
File path: java/refactoring.java/src/org/netbeans/modules/refactoring/java/ui/UIUtilities.java
##########
@@ -64,7 +64,14 @@
      * @see org.netbeans.api.java.source.ElementHandle
      */
     public static EnumSet allowedElementKinds = EnumSet.of(ElementKind.PACKAGE, ElementKind.CLASS, ElementKind.INTERFACE, ElementKind.ENUM, ElementKind.ANNOTATION_TYPE, ElementKind.METHOD, ElementKind.CONSTRUCTOR, ElementKind.INSTANCE_INIT, ElementKind.STATIC_INIT, ElementKind.FIELD, ElementKind.ENUM_CONSTANT, ElementKind.TYPE_PARAMETER);
-
+    static {
+        ElementKind recKind = null;
+        try {
+            recKind = ElementKind.valueOf("RECORD"); //NOI18N

Review comment:
       comments addressed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists