You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/13 01:54:39 UTC

[GitHub] [incubator-tvm] lfengad commented on a change in pull request #5042: [TF][Relay] TensorFlow Frontend support with shared params

lfengad commented on a change in pull request #5042: [TF][Relay] TensorFlow Frontend support with shared params
URL: https://github.com/apache/incubator-tvm/pull/5042#discussion_r391990959
 
 

 ##########
 File path: python/tvm/relay/frontend/tensorflow.py
 ##########
 @@ -77,10 +77,21 @@ def _dim_check(attrs):
         return False
     return _dim_check, "Only 2d or 3d kernel supported."
 
+# Build count_used to record params have been converted to attrs
+used_params = {}
 
 Review comment:
   Thank you for the suggestions! Then I think the thing to do is simple and we can just remove  the pop operations. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services