You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/19 18:54:42 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #12490: Remove unused/uncompiled JS file
ryanahamilton opened a new pull request #12490:
URL: https://github.com/apache/airflow/pull/12490
`graph.js` was not being compiled into executable JavaScript since it [wasn't explicitly declared in the `webpack.config.js`](https://github.com/apache/airflow/blob/master/airflow/www/webpack.config.js#L45).
```js
entry: {
// This line:
graph: `${STATIC_DIR}/css/graph.css`,
// should have been:
graph: [`${STATIC_DIR}/css/graph.css`, `${STATIC_DIR}/js/graph.js`],
}
```
This issue is moot as the [functionality was moved/rewritten inline](https://github.com/apache/airflow/blob/master/airflow/www/templates/airflow/graph.html#L459-L476) within the `graph.html` template file at some point. To that end, I've simply deleted the file and confirmed the functionality still persists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12490: Remove unused/uncompiled JS file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12490:
URL: https://github.com/apache/airflow/pull/12490#issuecomment-730577335
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #12490: Remove unused/uncompiled JS file
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #12490:
URL: https://github.com/apache/airflow/pull/12490
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org