You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/06/09 08:21:23 UTC

[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request, #2842: [TEST] Optimize the output of ExceptionThrowingDelegationTokenProvider in the Test

cxzl25 opened a new pull request, #2842:
URL: https://github.com/apache/incubator-kyuubi/pull/2842

   ### _Why are the changes needed?_
   
   Now kyuubi-server runs some tests that are not `HadoopCredentialsManagerSuite`, `ExceptionThrowingDelegationTokenProvider` still throws exception.
   ```
   Caused by: java.lang.IllegalArgumentException
   	at org.apache.kyuubi.credentials.ExceptionThrowingDelegationTokenProvider.<init>(HadoopCredentialsManagerSuite.scala:229) 
   ```
   
   In this PR, I limit it to `HadoopCredentialsManagerSuite` to allow exceptions to be thrown. Other suites can load this provider by default, but it does not affect other suite tests.
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2842: [TEST] Optimize the output of ExceptionThrowingDelegationTokenProvider in the Test

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #2842: [TEST] Optimize the output of ExceptionThrowingDelegationTokenProvider in the Test
URL: https://github.com/apache/incubator-kyuubi/pull/2842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2842: [TEST] Optimize the output of ExceptionThrowingDelegationTokenProvider in the Test

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2842:
URL: https://github.com/apache/incubator-kyuubi/pull/2842#issuecomment-1151120788

   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2842](https://codecov.io/gh/apache/incubator-kyuubi/pull/2842?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4729ced) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/ead33d79771ca422319032f32f93fe5f1f264f49?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ead33d7) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 4729ced differs from pull request most recent head 477fbb5. Consider uploading reports for the commit 477fbb5 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2842      +/-   ##
   ============================================
   + Coverage     63.37%   63.38%   +0.01%     
   - Complexity      203      205       +2     
   ============================================
     Files           485      485              
     Lines         21731    21731              
     Branches       2864     2864              
   ============================================
   + Hits          13771    13774       +3     
   + Misses         6659     6656       -3     
     Partials       1301     1301              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `85.00% <0.00%> (+0.62%)` | :arrow_up: |
   | [...ache/kyuubi/spark/connector/tpch/TPCHCatalog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstY29ubmVjdG9yLXRwY2gvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvc3BhcmsvY29ubmVjdG9yL3RwY2gvVFBDSENhdGFsb2cuc2NhbGE=) | `57.14% <0.00%> (+2.38%)` | :arrow_up: |
   | [...apache/kyuubi/spark/connector/tpch/TPCHTable.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstY29ubmVjdG9yLXRwY2gvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvc3BhcmsvY29ubmVjdG9yL3RwY2gvVFBDSFRhYmxlLnNjYWxh) | `52.00% <0.00%> (+4.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2842?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2842?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ead33d7...477fbb5](https://codecov.io/gh/apache/incubator-kyuubi/pull/2842?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2842: [TEST] Optimize the output of ExceptionThrowingDelegationTokenProvider in the Test

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #2842:
URL: https://github.com/apache/incubator-kyuubi/pull/2842#issuecomment-1151862567

   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org